From owner-svn-ports-head@FreeBSD.ORG  Sun Feb 22 16:32:29 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2446312C;
 Sun, 22 Feb 2015 16:32:29 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F2DD475F;
 Sun, 22 Feb 2015 16:32:28 +0000 (UTC)
Received: from [192.168.0.133] (vie-188-118-240-003.dsl.sil.at [188.118.240.3])
 by ainaz.pair.com (Postfix) with ESMTPSA id B63593F4D5;
 Sun, 22 Feb 2015 11:32:25 -0500 (EST)
Date: Sun, 22 Feb 2015 17:32:23 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Thomas Zander <riggs@FreeBSD.org>, phd_kimberlite@yahoo.co.jp
Subject: Re: svn commit: r379512 - in head/math/openblas: . files
In-Reply-To: <201502211340.t1LDeKhn057393@svn.freebsd.org>
Message-ID: <alpine.LSU.2.11.1502221728200.4743@tuna.site>
References: <201502211340.t1LDeKhn057393@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Feb 2015 16:32:29 -0000

On Saturday 2015-02-21 13:40, Thomas Zander wrote:
> Log:
>   Add support for clang
>   
>   PR:		197385
>   Submitted by:	phd_kimberlite@yahoo.co.jp (maintainer)

> -USE_GCC=	yes

So far, so good.

> -	-e 's+%%_GCC_RUNTIME%%+${_GCC_RUNTIME}+' \
> +	-e 's+%%_GCC_VER%%+${_GCC_VER}+' \

This looks scary.  Why do you replace one variable starting with
an underscore by another variable starting with an underscore when
in Unix-land this convention means "internal use; not to be used
by regular users"?

> Modified: head/math/openblas/files/patch-Makefile.system
> ==============================================================================
> -+FCOMMON_OPT	+= -Wl,-rpath=%%_GCC_RUNTIME%%
> ++FCOMMON_OPT	+= -Wl,-rpath=%%LOCALBASE%%/lib/gcc%%_GCC_VER%%

And here it becomes really worrisome.  Instead of the internal
variable that at least had the full path set in a transparent
manner, now you construct this manually?  Totally relying on
implementation details that can (and likely _will_) change?

And without USE_GCC set, _GCC_VER is not going to set either,
is it?

I'm afraid something is broken here.  Can you please address it?

Gerald