From owner-freebsd-current Tue Jan 15 17:12: 5 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id 7837137B417 for ; Tue, 15 Jan 2002 17:11:58 -0800 (PST) Received: (qmail 1951 invoked from network); 16 Jan 2002 01:11:57 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 16 Jan 2002 01:11:57 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020116010414.GA425@laptop.hackerheaven.org> Date: Tue, 15 Jan 2002 17:11:14 -0800 (PST) From: John Baldwin To: Emiel Kollof Subject: Re: Netatalk broken in current? Lock order reversal? Cc: freebsd-current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 16-Jan-02 Emiel Kollof wrote: > * John Baldwin (jhb@FreeBSD.org) wrote: >> >> > lock order reversal 1st 0xc185e934 filedesc structure @ >> > /usr/src/sys/kern/kern_descrip.c:925 >> > 2nd 0xc0419b00 Giant @ /usr/src/sys/kern/kern_descrip.c:959 >> >> This one is due to not releasing the filedesc lock when grabbing Giant to >> free >> oldofile in fdalloc(). > > Is that going to cause data loss? I also saw messages like these: > > /var: lost blocks 62 files 8 No, that's softupdates stuff. I think releasing filedesc is ok this case, but usually I would recode it to move malloc's and free's around to avoid having to drop and reacquire locks. >> Having the actual panic messages would be very helpful here. > > It crashed very reproducable with this panic (hand copied): > > exclusive (sleep mutex) Giant (0xc0462c00) locked @ > /usr/src/sys/i386/i386/trap.c:1102 > panic: system call pwrite returning with mutex(s) held Hmm, erm, go kick Alfred really hard. :) This function locks Giant and then doesn't ever unlock it. This looks to be breakage from his fget() changes perhaps. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message