From owner-cvs-src@FreeBSD.ORG Tue Aug 2 12:06:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FA6016A41F; Tue, 2 Aug 2005 12:06:38 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A1EC43D46; Tue, 2 Aug 2005 12:06:37 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5ECA6.dip.t-dialin.net [84.165.236.166]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id j72C3GPO035245; Tue, 2 Aug 2005 14:03:29 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id j72C5b7N069795; Tue, 2 Aug 2005 14:05:37 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from 141.113.101.31 ([141.113.101.31]) by netchild.homeip.net (Horde MIME library) with HTTP for ; Tue, 02 Aug 2005 14:05:36 +0200 Message-ID: <20050802140536.zstn68rcgsg84g0w@netchild.homeip.net> X-Priority: 3 (Normal) Date: Tue, 02 Aug 2005 14:05:36 +0200 From: Alexander Leidinger To: Ruslan Ermilov , imp@FreeBSD.org References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no> <20050731102343.35bc4aa9@Magellan.Leidinger.net> <20050802090717.GK14023@ip.net.ua> In-Reply-To: <20050802090717.GK14023@ip.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: Dag-Erling Sm?rgrav , src-committers@FreeBSD.org, Peter Grehan , cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2005 12:06:38 -0000 Ruslan Ermilov wrote: > On Sun, Jul 31, 2005 at 10:23:43AM +0200, Alexander Leidinger wrote: >> On Sun, 31 Jul 2005 09:31:59 +0200 >> des@des.no (Dag-Erling Sm?rgrav) wrote: >> >> > Alexander Leidinger writes: >> > > What's more preferred, the use of ".error", or the way you solved it? >> > >> > depends on what you think should happen if a user tries >> > >> > # make installworld delete-old >> >> Ok, point taken. >> >> > BTW, I don't really see why {check,delete}-old-* should be restricted >> > to native environments. DESTDIR might point to e.g. an NFS-exported >> > filesystem from which thin clients of a different architecture boot. >> >> Because of ObsoleteFiles.inc: >> ---snip--- >> .if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "sparc64" >> # 20040130: libkse renamed to libpthread >> OLD_FILES+=usr/lib/libkse.a >> OLD_FILES+=usr/lib/libkse.so >> .endif >> ---snip--- >> >> We could change this to TARGET_ARCH instead, but then the user has to >> set it, else he removes non-obsolete files. Even when we make it a >> documented requirement, I don't have a good feeling regarding this. >> There's too much foot-shooting potential if someone forgets to set it. >> I think it's more user friendly / ergonomic to keep the current >> restriction. With the restriction in place you need to have 2 >> files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src >> directory on one client to remove the old files. This is a little bit >> more work, but forces the administrator to think a little bit about what >> he does. It's part of my "as failsafe as possible" design of this >> feature. >> >> I don't object when someone wants to remove the restriction based upon >> a decission of a majority (committers, user complains, whatever). >> > TARGET_ARCH is always set in Makefile.inc1. It's set to MACHINE_ARCH > by default. It should be safe to s/MACHINE_ARCH/TARGET_ARCH/ in > ObsoleteFiles.inc and remove the condition for nativeness. I wasn't talking about technical restrictions. I know that TARGET_ARCH is always set, else the MACHINE_ARCH != TARGET_ARCH check wouldn't work. When an user calls delete-old with DESTDIR set to the root of a non-native machine architecture he may remove non-obsolete files when he forgets to set TARGET_ARCH. I want to prevent this situation. I think "failsafe" is more important than "POLA" in this case. Warner said it's unlikely that someone will use this feature in a cross-arch situation (at least I did understand it this way), so what about waiting until we get user-feedback for this case? Bye, Alexander. -- http://www.Leidinger.net/ Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org/ netchild @ FreeBSD.org : PGP ID = 72077137 The Heineken Uncertainty Principle: You can never be sure how many beers you had last night. fr