From owner-svn-src-all@freebsd.org Fri Feb 22 16:50:33 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46C4014F30F6; Fri, 22 Feb 2019 16:50:33 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA87D752EC; Fri, 22 Feb 2019 16:50:32 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.1.183] (unknown [209.133.79.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id B313B27001A3; Fri, 22 Feb 2019 11:50:24 -0500 (EST) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu B313B27001A3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1550854225; bh=ZHmBPfZ+V4U+TkkgymRI0crZ+l71lc4Er4X2HWNGdeQ=; h=Subject:To:From:Date:From; b=tR+dTHjjPAcoEN34yxAxBpZgfTsKQr6zoePRlwali1CJKj6JXTRmyVh+clo9DId4E WCiuw8XJ+Nnbkv84C+COvsKxeQ8i/XIp9CE7OdUxvEHIg+E2cF37HOLsRUk+zsDj3b f3k0jmC73BhO8lvKOzWm6JcQAaPNIXZFLyS6oN7j2BI8XMmAJctZ4xkPKAphuoVvV5 QyFF3mU6xCajy2fmHLYBfk3rTUmjL01vFpxIjl1CKg9wNl4wyVbeUIQvXnrCuG0ZbD 8qgaE1Au7LMDMn9jxjhjp/nkyCzaDlw2bDPZ9aKb/IdIj9ZJmCHogIFK0pgpXgV8jt jkdEIfR/Ao2FA== Subject: Re: svn commit: r344099 - head/sys/net To: John Baldwin , Randall Stewart Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201902131457.x1DEvx9V051533@repo.freebsd.org> <99453977-0f52-6050-3f40-e0fd7ea43d7f@FreeBSD.org> <80314D46-6FEC-462D-8EC5-FCE1ECFF81EF@netflix.com> <89d15ffe-1bc9-adaf-9307-4bf6541cc5e1@FreeBSD.org> <1dcae85d-2a3a-1e7c-4692-c62f87020096@FreeBSD.org> From: Andrew Gallatin Message-ID: <50bda411-2705-5a5d-2a0f-6bf3bfbfb2ef@cs.duke.edu> Date: Fri, 22 Feb 2019 11:50:23 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1dcae85d-2a3a-1e7c-4692-c62f87020096@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DA87D752EC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.938,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 16:50:33 -0000 I think the misunderstanding here is that I think he's not getting the ifp from the route. My recollection is that he is holding the ifps when he enables HW pacing in BBR. Due to limitations in different NIC hardware, you can only have N different rates, etc. So he goes ahead and allocates those N rates up front so that he knows he can reserve them & know that he can always get them. Then when the system reboots, BBR has an eventhandler that goes ahead and frees those reservations. I think that he's using the ifp that he's holding here. In the case that tripped him up, that ifp was lagg. Your workaround would also work, but Randall does have a point about symmetric alloc/free especially when viewed from his perspective, Drew