From owner-freebsd-x11@FreeBSD.ORG Fri Sep 9 09:10:04 2005 Return-Path: X-Original-To: freebsd-x11@hub.freebsd.org Delivered-To: freebsd-x11@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4BCE16A42B for ; Fri, 9 Sep 2005 09:10:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70F9343D49 for ; Fri, 9 Sep 2005 09:10:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j899A4Vg051343 for ; Fri, 9 Sep 2005 09:10:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j899A4O0051342; Fri, 9 Sep 2005 09:10:04 GMT (envelope-from gnats) Date: Fri, 9 Sep 2005 09:10:04 GMT Message-Id: <200509090910.j899A4O0051342@freefall.freebsd.org> To: freebsd-x11@FreeBSD.org From: Sergey Skvortsov Cc: Subject: Re: ports/85735: Force imake respect CC/CXX X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sergey Skvortsov List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2005 09:10:04 -0000 The following reply was made to PR ports/85735; it has been noted by GNATS. From: Sergey Skvortsov To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/85735: Force imake respect CC/CXX Date: Fri, 09 Sep 2005 13:00:12 +0400 Dejan Lesjak wrote: >>You used unexisting cc. Try the real one - install lang/gcc34. > > Ah, my testcase was flawed as I feared. Thanks for the cluebat :) > > Do you agree though that changing FreeBSD.cf as in patch would not be optimal > wrt hardcoding $CC and $CXX in installed imake configuration? If so, here's > what I'm considering now: we can add the following two lines to ports > Makefile: > > MAKE_ENV+= MAKEFLAGS="CC=${CC} CXX=${CXX}" > SCRIPTS_ENV+= CC=${CC} > > and modify the last two lines in scripts/configure to: > > env MAKEFLAGS="CC=${CC}" make Makefile.boot > env MAKEFLAGS="CC=${CC}" make -f xmakefile VerifyOS version.def Makefiles > includes > > Would this kind of change make sense? > If so, the CFLAGS could also be fixed in same way. Your approach seems to be more correct, however the result is still the same (I just try to avoid creating new patch-* files). I also see another problem. Imake.tmpl is created while imake building and installed into /usr/X11R6/lib/X11/config/Imake.tmpl. This template will be used for all imake-depended ports. But futher compiling such ports with another CC/CXX values may cause strangest errors. Some method for detection this situation should be introduced. -- Sergey Skvortsov mailto: skv@FreeBSD.org