From owner-cvs-sbin Mon May 11 00:42:53 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA28295 for cvs-sbin-outgoing; Mon, 11 May 1998 00:42:53 -0700 (PDT) (envelope-from owner-cvs-sbin) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA28080; Mon, 11 May 1998 00:42:02 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id AAA27739; Mon, 11 May 1998 00:38:43 -0700 (PDT) Date: Mon, 11 May 1998 00:38:43 -0700 (PDT) Message-Id: <199805110738.AAA27739@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sbin@FreeBSD.ORG Subject: cvs commit: src/sbin/umount umount.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/05/11 00:38:43 PDT Modified files: sbin/umount umount.c Log: Fix PR 1607, hopefully without breaking the PR 5208 fixes. umount() was trying to stat() the mountpoint, this would fail if the mountpoint was a NFS mountpoint, and the fallback code would try and pass a hostname:/dir path as the mountpoint to unmount(2), which would fail. This whole stat() of the name supplied on the command line business is trouble as it'll wedge on a hung NFS mount. I'm not entirely sure why we are not simply looking up both arguments in the mount table and doing the right thing without accessing the filesystem. It seems that we're going to a lot of trouble to allow mountpoints on symlinks and other wierd things. PR: 1607 Revision Changes Path 1.14 +7 -7 src/sbin/umount/umount.c