From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 27 22:10:44 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D638C16A4E3 for ; Mon, 27 Sep 2004 22:10:44 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD0FD43D58 for ; Mon, 27 Sep 2004 22:10:36 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i8RMAaqK004194 for ; Mon, 27 Sep 2004 22:10:36 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8RMAaSW004193; Mon, 27 Sep 2004 22:10:36 GMT (envelope-from gnats) Resent-Date: Mon, 27 Sep 2004 22:10:36 GMT Resent-Message-Id: <200409272210.i8RMAaSW004193@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michel Lavondes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1BC616A4CE for ; Mon, 27 Sep 2004 22:09:23 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C571043D39 for ; Mon, 27 Sep 2004 22:09:23 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i8RM9L5Q088111 for ; Mon, 27 Sep 2004 22:09:21 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i8RM9LWK088110; Mon, 27 Sep 2004 22:09:21 GMT (envelope-from nobody) Message-Id: <200409272209.i8RM9LWK088110@www.freebsd.org> Date: Mon, 27 Sep 2004 22:09:21 GMT From: Michel Lavondes To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: ports/72137: make clean crashes in x11/nvidia-driver too. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2004 22:10:45 -0000 >Number: 72137 >Category: ports >Synopsis: make clean crashes in x11/nvidia-driver too. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 27 22:10:36 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Michel Lavondes >Release: 4.8-RELEASE-p25 >Organization: Ecdysiasts United for Overdressing >Environment: >Description: # cd /usr/ports/x11/nvidia-driver; make clean "Makefile", line 44: warning: String comparison operator should be either == or != "Makefile", line 44: Malformed conditional (${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001)) "Makefile", line 44: Missing dependency operator "Makefile", line 46: if-less endif "Makefile", line 46: Need an operator make: fatal errors encountered -- cannot continue Note: this is a near-duplicate of ports/72118, http://www.freebsd.org/cgi/query-pr.cgi?pr=72118 >How-To-Repeat: See above "Full Description" >Fix: Change line 44 of Makefile from: .if ${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001) to .if ${OSVERSION} < 490000 || ${OSVERSION} >= 500000 && ${OSVERSION} < 502001 Note: make(1) states that && has higher precedence than ||, so the () shouldn't be necessary. Just to be on the safe side (I don't have the resources to test on other FreeBSD versions), I checked my fix with: # make -V OSVERSION 480000 # make -V IGNORE "supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)" # make -V IGNORE OSVERSION=489999 "supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)" # make -V IGNORE OSVERSION=490000 # make -V IGNORE OSVERSION=499999 # make -V IGNORE OSVERSION=500000 "supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)" # make -V IGNORE OSVERSION=502000 "supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)" # I hope I didn't overlook anything. >Release-Note: >Audit-Trail: >Unformatted: