From owner-svn-src-head@freebsd.org Fri Mar 3 07:15:24 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 387ABCF567F; Fri, 3 Mar 2017 07:15:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 02B4E1ED6; Fri, 3 Mar 2017 07:15:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x22b.google.com with SMTP id s67so41102858pgb.3; Thu, 02 Mar 2017 23:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=2eq+1Q6VkNfXRMbrljDOG33Lat9Y3VtIvoImCjss0h8=; b=LoAwdUBJYtts+AhVw0o25UB05NdfNUdhO3ddU2KbTMRIamxVUAIZpaLzYhJTCRZN8O IBGpcVEopP0RTcHsklZ+K44yM/9O30v3/D9HfntDdOXDHRQ60ZQ+s/vOG1lAB2XoGZ2z IB6F1V27hcBu0KpHEbk7c2dFIvBxwWsoKBuPQJFG22ABDlYPAd/mVSrmqDSTZmmT6qxn Qx6cCP2PPS3gv0G5ZOaKhBv+xXQAgpGxxqhUPUpSh5ZjOr0dMCN2L9VbZYNNr8fS40+I SzOi8DlxTv2ZkuLv5Y4+s+WJ0l1rO/oc8s/0kQDQHY9tWGhJOATHHVK9VJ80HUVgIv0l sTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=2eq+1Q6VkNfXRMbrljDOG33Lat9Y3VtIvoImCjss0h8=; b=S56CRzamQ4zYzj0S6Zaf/ZuwBmdQArn5R71yYGrWzyYrwFJrQudvOe438MuYyGnIZA r7+qxqDfaOIBappD6fWdlDUVw0xCdAtZ7oS7lA7etNvKIMZxnMTcByvERAVvG4+rWBW/ HOY2J/Qk8oLJFo04SgzwC3+iWGcRlBAWoIf6UC1fjW0/j0VdpP1Zrgq3KIuJLvl8tCnz faep5vJbiWMVkRGFhpaFL6Ns4JMCB+WSLronaKjkEoIvjcGPRLXb8LNz157kqvw4BieF skb+ExjO9oe5E+SbQUA+5MjcPl0EiirriO4bSENWAJuYftGvLaD0s9veA41E4kMVnxw0 FpUA== X-Gm-Message-State: AMke39nWjQElEkrmFgqXrthKHRHjoWDbZrODjF3iAaVKp9B2hemclqE6rIlNGnog8aad8Q== X-Received: by 10.99.115.12 with SMTP id o12mr1613772pgc.165.1488525323415; Thu, 02 Mar 2017 23:15:23 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 2sm2351093pfx.76.2017.03.02.23.15.22 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 02 Mar 2017 23:15:22 -0800 (PST) Subject: Re: svn commit: r314585 - head/usr.sbin/syslogd Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B9742E12-4BFE-4171-AE3A-C170003BB903"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <3B6DBB8E-B9AF-46DF-BDEA-9D51DF132BA6@gmail.com> Date: Thu, 2 Mar 2017 23:15:21 -0800 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <1A3F6606-822C-4C80-ADFA-48378F0F29EE@gmail.com> References: <201703030613.v236DxDl010255@repo.freebsd.org> <20170303.154955.607107599855581369.hrs@allbsd.org> <3B6DBB8E-B9AF-46DF-BDEA-9D51DF132BA6@gmail.com> To: Hiroki Sato X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 07:15:24 -0000 --Apple-Mail=_B9742E12-4BFE-4171-AE3A-C170003BB903 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 2, 2017, at 23:13, Ngie Cooper (yaneurabeya) = wrote: >=20 >>=20 >> On Mar 2, 2017, at 22:49, Hiroki Sato wrote: >>=20 >> Ngie Cooper wrote >> in <201703030613.v236DxDl010255@repo.freebsd.org>: >>=20 >> ng> Author: ngie >> ng> Date: Fri Mar 3 06:13:59 2017 >> ng> New Revision: 314585 >> ng> URL: https://svnweb.freebsd.org/changeset/base/314585 >> ng> >> ng> Log: >> ng> Correct verb change for service =3D> `*` after r314563 >> ng> >> ng> `*` means that packets will be received from a remote peer on = any port. >> ng> Since the point of interest is the syslogd instance (not the = remote peer), >> ng> the appropriate verb is "received", not "sent". >> ng> >> ng> MFC after: 1 month >> ng> X-MFC with: r314563 >> ng> Sponsored by: Dell EMC Isilon >> ng> >> ng> Modified: >> ng> head/usr.sbin/syslogd/syslogd.8 >> ng> >> ng> Modified: head/usr.sbin/syslogd/syslogd.8 >> ng> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> ng> --- head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:06:27 2017 = (r314584) >> ng> +++ head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:13:59 2017 = (r314585) >> ng> @@ -131,7 +131,7 @@ A >> ng> .Ar service >> ng> of >> ng> .Ql \&* >> ng> -allows packets to be sent from any UDP port. >> ng> +allows packets to be received from any UDP port. >> ng> The default >> ng> .Ar service >>=20 >> It is incorrect that syslogd receives a UDP packet on any local port >> when a "*" is specified. This address validation is done by using >> the source port number in a received UDP packet, so the point of >> interest is the remote peer. >>=20 >> How about "...accepts UDP packets sent with any source port" or >> something? >=20 > Yeah, that=E2=80=99s more accurate. How about this? -Ngie $ svn diff usr.sbin/syslogd/syslogd.8 Index: usr.sbin/syslogd/syslogd.8 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.sbin/syslogd/syslogd.8 (revision 314585) +++ usr.sbin/syslogd/syslogd.8 (working copy) @@ -131,7 +131,7 @@ .Ar service of .Ql \&* -allows packets to be received from any UDP port. +allows UDP packets to be sent with any source port. The default .Ar service is --Apple-Mail=_B9742E12-4BFE-4171-AE3A-C170003BB903 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYuRgKAAoJEPWDqSZpMIYVmAoQAJGtg1OrJ8PlolGpH8TqPcbE QA3MB2uSO9azBwmpWH6Sthb1tHNodCIO4e8S/mW4g69DPuqeKm7U0CgrXIUEExWZ LWmGzMMIElRckLhNk9sOuTMbjxr+/E01X2Oh0mPJA+7M5Czaj2dra3BBSrNl/uWJ JIG7iphnddPHp26txiUaL1gAOneB8SuhzLO7dJbrfZFSEvGHpZ8XsTdH7zD1Y3hc NI2N3+LxEsVbstPPhulRGe7DU2wxMphmiYJ53/mVQ4HTou2E6OWjL++RcaH2Ddlp j1sDR10plceXxn8fVOjYiwyniX/rSRctM97iaWL0gVEnUOi3pnxOm/Rjo0gKcrwN isv0yFbKEmLBAknBK+NQsZEzsXDYCUUSGUxInEBRYLLS8Am+ks+SWnYYfCLgLqsW p6ZJEGPPuFCiUPTzngnKx16XulgUVgbVKSkmRoNgClrb75Jq28+DodYUCvc32zW1 BZ1W1RVUGMQfBebGlO9U7Cq4iYRGs7rgwqtBQd4uP/VW7LCi7iwpdq7mNg67I5kd 1l9bysTLkTH7R8VginWqCc5rmibygP1xKNPHYLGvnVnm5D1f1FxsqKgAUVhvAvZh CyzBu1uquNSdBTW8Mazp/WJ/fadqTuz083WesLtuYC/BT6Vt8GoIGEp0M4Gnv6yt e9w2ws4kgJK99CrDf+Hw =8eSm -----END PGP SIGNATURE----- --Apple-Mail=_B9742E12-4BFE-4171-AE3A-C170003BB903--