From owner-freebsd-virtualization@FreeBSD.ORG Fri Jul 6 05:53:22 2012 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 939931065676 for ; Fri, 6 Jul 2012 05:53:22 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 208A78FC0C for ; Fri, 6 Jul 2012 05:53:21 +0000 (UTC) Received: by werp13 with SMTP id p13so5631930wer.13 for ; Thu, 05 Jul 2012 22:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:organization:references:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=NkqngIlHEy5LWmaGMnG75fD5aS0rQ6bp05z5XkXZd/g=; b=AmYVlMiTKaF7JO+zmMIe5dbCtx6vskhNWOD6bl9fmG7k9okWa20Np/rpdwODFZS/iL 8aqpoR/IKd87tUIHrT9mmHeKecfsxunmFGWmY4lKu7A5/a7l0/ev6bj5L8yBAzuQIGPH 7nGjJ3wjYFCfdrhpZzhkasoqvwFw8Z1aSJGmmP65A1u7KSmYuyJ0aDJ/YS5IPvG2DXL2 V/NZfNzeBnipYu70UombMAw7D+PG+8h88TUn3h5QGPxf0AeroOHmdWsRQA2PIzHsjcFV MsNty9gM38pMAjD3Wdqpw1FcMEG5uiPRW2s7Nt/IrInM24ErKmh76M+9o6haEE0tlvrh XB9w== Received: by 10.180.106.97 with SMTP id gt1mr4890988wib.5.1341554001169; Thu, 05 Jul 2012 22:53:21 -0700 (PDT) Received: from localhost ([188.230.122.226]) by mx.google.com with ESMTPS id e9sm6169125wiw.10.2012.07.05.22.53.18 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 Jul 2012 22:53:19 -0700 (PDT) From: Mikolaj Golub To: "Bjoern A. Zeeb" Organization: TOA Ukraine References: <4FF32FC4.6020701@delphij.net> <86wr2kau38.fsf@in138.ua3> <4FF5E87C.2020908@delphij.net> <86r4sqasrt.fsf@kopusha.home.net> <672D93D3-D4B1-432E-AE53-98E6C05B8BE4@lists.zabbadoz.net> Sender: Mikolaj Golub Date: Fri, 06 Jul 2012 08:53:17 +0300 In-Reply-To: <672D93D3-D4B1-432E-AE53-98E6C05B8BE4@lists.zabbadoz.net> (Bjoern A. Zeeb's message of "Thu, 5 Jul 2012 20:21:53 +0000") Message-ID: <86zk7da10y.fsf@in138.ua3> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: d@delphij.net, FreeBSD virtualization mailing list Subject: Re: GPF when doing jail -r, possibly an use-after-free X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2012 05:53:22 -0000 On Thu, 5 Jul 2012 20:21:53 +0000 Bjoern A. Zeeb wrote: BAZ> On 5. Jul 2012, at 19:53 , Mikolaj Golub wrote: >> >> On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: >> >> XL> Hi, Mikolaj, >> >> XL> On 07/04/12 00:00, Mikolaj Golub wrote: >>>> Is this observed after destroying epair? There is an issue with >>>> epair: on destroy, when epair_clone_destroy() calls >>>> ether_ifdetach() for its second half it does not switch to its vnet >>>> and if_detach_internal() can't find the interface and just returns. >>>> As a result V_ifnet list is left with dead reference. >> >> XL> Yes. >> >>>> http://lists.freebsd.org/pipermail/freebsd-virtualization/2011-January/000628.html >>>> >>>> Here is an updated patch against CURRENT: >>>> >>>> http://people.freebsd.org/~trociny/if_epair.c.epair_clone_destroy.1.patch >> >> XL> Your >>>> >> XL> patch did fixed the problem, thanks! Are you going to commit it >> XL> against -HEAD and then MFC after a while? >> >> I would like Bjoern review it before me committing, or at least tell he does >> not mind, if he does not have time to review -) BAZ> To me the patch looks wrong; I am wondering if someone broke some other central BAZ> assumptions but given I cannot currently spend time on this and if it fixes things BAZ> feel free to go ahead. If you told what looks wrong I could try to dig at that direction and might be back with a better solution, instead of committing a presumably wrong fix. -- Mikolaj Golub