From owner-svn-ports-all@freebsd.org Tue May 5 08:01:11 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id 981862DBBDD;
Tue, 5 May 2020 08:01:11 +0000 (UTC)
(envelope-from bapt@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
server-signature RSA-PSS (4096 bits)
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "smtp.freebsd.org",
Issuer "Let's Encrypt Authority X3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 49GXGv3Xnqz4VC1;
Tue, 5 May 2020 08:01:11 +0000 (UTC)
(envelope-from bapt@FreeBSD.org)
Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate) (Authenticated sender: bapt)
by smtp.freebsd.org (Postfix) with ESMTPSA id 5D49F10731;
Tue, 5 May 2020 08:01:11 +0000 (UTC)
(envelope-from bapt@FreeBSD.org)
Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001)
id 1012AD862E; Tue, 5 May 2020 10:01:09 +0200 (CEST)
Date: Tue, 5 May 2020 10:01:09 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Dirk Meyer <dinoex@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
svn-ports-head@freebsd.org
Subject: Re: svn commit: r533992 - head/sysutils/xe-guest-utilities
Message-ID: <20200505080109.hk5zyihizii45amt@ivaldir.net>
References: <202005042146.044LkmjA009477@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="zalph3iya5jmtjch"
Content-Disposition: inline
In-Reply-To: <202005042146.044LkmjA009477@repo.freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2020 08:01:11 -0000
--zalph3iya5jmtjch
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, May 04, 2020 at 09:46:48PM +0000, Dirk Meyer wrote:
> Author: dinoex
> Date: Mon May 4 21:46:47 2020
> New Revision: 533992
> URL: https://svnweb.freebsd.org/changeset/ports/533992
>=20
> Log:
> - make RUN_DEPENDS more robust
>=20
> Modified:
> head/sysutils/xe-guest-utilities/Makefile
>=20
> Modified: head/sysutils/xe-guest-utilities/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sysutils/xe-guest-utilities/Makefile Mon May 4 21:45:08 2020 (r=
533991)
> +++ head/sysutils/xe-guest-utilities/Makefile Mon May 4 21:46:47 2020 (r=
533992)
> @@ -11,7 +11,7 @@ DISTNAME=3D ${PORTNAME}-6.0.2
> MAINTAINER=3D dinoex@FreeBSD.org
> COMMENT=3D FreeBSD VM tools for Citrix XenServer and XCP
> =20
> -RUN_DEPENDS=3D xen-guest-tools>0:${PKGCATEGORY}/xen-guest-tools
> +RUN_DEPENDS=3D ${LOCALBASE}/bin/xenstore:${PKGCATEGORY}/xen-guest-tools
how it is more robust?
1 finding a package (previous code) or finding the binary second code is bo=
th as
robust.
second I don't understand why you added the full path and not just xenstore=
:...
Last one should really directly write the origin of a package and not use a
variable that may changes, so ${PKGCATEGORY} both in new and old code at le=
ast
weird here.
Best regards,
Bapt
--zalph3iya5jmtjch
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl6xHUQACgkQY4mL3PG3
Plp+VQ/9F78Dmf4I6bXQOWeW1QwMSkcfh5Tvnd5TiSJRYZq9ajk+ZJjbN3m94mdV
twTLUu0/N8GdXsxcK7Q265YGtlrn2fr4IX0OcNKa5ByjMffJ0iQKNPlJAhyowPEM
R7UWnUaInQjqoC8ZFVTF7Z0E5P1CFdM5wBgkaauiYPpnGoCyNy6bNz6i2wFoqHW7
+BLRuBR0tON1j1m5nyDt0Kqz39knOP3MRD8u9wPki7ojV3IpoRgTQjFdtU5G6vyZ
BTNvBwrkepbUXpfC7vj8tMvmQhQTyhm8CgKgEzY1Abb9Qu/2BPE4UMK8YCdxq4q+
9xWeSMqWQNQICTtvKlhpcAxofmhEHqtjLeg/HUK3LohFhP/tDHcKFT2AKwujCOdg
QFs00wTgGa6SmTFKxsmBQ9oAoJ5onCeFC6KFsZN1GnXlzPWRT3x/oOIUMLOdG8vw
NzsqEGcWbBBXNuxXVaBlX5Z3eYH3+w8iqspbD46bj7cYLJU84Dy0ookelyVspH4c
XLu6HxPqMySRRUSOVtuja4kio0F1HuBaasdGhqhbwncLGXQL0TAhGkH4695qIVWY
lhY0o06m1Enbz1Now5wPe/Wf/mFm1AwUlcMTtZ7TsSrLUiIs+C8cWRKd64l3bZ68
h/ehD01ncgSyA5B2DgqQ9XeWhXv1ZxXZMZ/aWf1eMizaOyU/pwA=
=Bwgo
-----END PGP SIGNATURE-----
--zalph3iya5jmtjch--