Date: Tue, 5 May 2020 10:01:09 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r533992 - head/sysutils/xe-guest-utilities Message-ID: <20200505080109.hk5zyihizii45amt@ivaldir.net> In-Reply-To: <202005042146.044LkmjA009477@repo.freebsd.org> References: <202005042146.044LkmjA009477@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--zalph3iya5jmtjch Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 04, 2020 at 09:46:48PM +0000, Dirk Meyer wrote: > Author: dinoex > Date: Mon May 4 21:46:47 2020 > New Revision: 533992 > URL: https://svnweb.freebsd.org/changeset/ports/533992 >=20 > Log: > - make RUN_DEPENDS more robust >=20 > Modified: > head/sysutils/xe-guest-utilities/Makefile >=20 > Modified: head/sysutils/xe-guest-utilities/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sysutils/xe-guest-utilities/Makefile Mon May 4 21:45:08 2020 (r= 533991) > +++ head/sysutils/xe-guest-utilities/Makefile Mon May 4 21:46:47 2020 (r= 533992) > @@ -11,7 +11,7 @@ DISTNAME=3D ${PORTNAME}-6.0.2 > MAINTAINER=3D dinoex@FreeBSD.org > COMMENT=3D FreeBSD VM tools for Citrix XenServer and XCP > =20 > -RUN_DEPENDS=3D xen-guest-tools>0:${PKGCATEGORY}/xen-guest-tools > +RUN_DEPENDS=3D ${LOCALBASE}/bin/xenstore:${PKGCATEGORY}/xen-guest-tools how it is more robust? 1 finding a package (previous code) or finding the binary second code is bo= th as robust. second I don't understand why you added the full path and not just xenstore= :... Last one should really directly write the origin of a package and not use a variable that may changes, so ${PKGCATEGORY} both in new and old code at le= ast weird here. Best regards, Bapt --zalph3iya5jmtjch Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl6xHUQACgkQY4mL3PG3 Plp+VQ/9F78Dmf4I6bXQOWeW1QwMSkcfh5Tvnd5TiSJRYZq9ajk+ZJjbN3m94mdV twTLUu0/N8GdXsxcK7Q265YGtlrn2fr4IX0OcNKa5ByjMffJ0iQKNPlJAhyowPEM R7UWnUaInQjqoC8ZFVTF7Z0E5P1CFdM5wBgkaauiYPpnGoCyNy6bNz6i2wFoqHW7 +BLRuBR0tON1j1m5nyDt0Kqz39knOP3MRD8u9wPki7ojV3IpoRgTQjFdtU5G6vyZ BTNvBwrkepbUXpfC7vj8tMvmQhQTyhm8CgKgEzY1Abb9Qu/2BPE4UMK8YCdxq4q+ 9xWeSMqWQNQICTtvKlhpcAxofmhEHqtjLeg/HUK3LohFhP/tDHcKFT2AKwujCOdg QFs00wTgGa6SmTFKxsmBQ9oAoJ5onCeFC6KFsZN1GnXlzPWRT3x/oOIUMLOdG8vw NzsqEGcWbBBXNuxXVaBlX5Z3eYH3+w8iqspbD46bj7cYLJU84Dy0ookelyVspH4c XLu6HxPqMySRRUSOVtuja4kio0F1HuBaasdGhqhbwncLGXQL0TAhGkH4695qIVWY lhY0o06m1Enbz1Now5wPe/Wf/mFm1AwUlcMTtZ7TsSrLUiIs+C8cWRKd64l3bZ68 h/ehD01ncgSyA5B2DgqQ9XeWhXv1ZxXZMZ/aWf1eMizaOyU/pwA= =Bwgo -----END PGP SIGNATURE----- --zalph3iya5jmtjch--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200505080109.hk5zyihizii45amt>