Date: Thu, 13 Apr 2017 15:00:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r438413 - in head/devel: . debugedit debugedit/files Message-ID: <20170413150057.GB86375@FreeBSD.org> In-Reply-To: <201704122049.v3CKnQS9032104@repo.freebsd.org> References: <201704122049.v3CKnQS9032104@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 12, 2017 at 08:49:26PM +0000, Maxim Sobolev wrote: > New Revision: 438413 > URL: https://svnweb.freebsd.org/changeset/ports/438413 > > Log: > Add debugedit - ELF file debug information extractor and editor. > > ... > +PORTVERSION= 20170411.1 > +#PORTREVISION= 1 Strange port version (2017.04.11.1 would look more consistent), and polluting the Makefile with commented out useless lines is bad. :-) > +USE_GITHUB= yes > +GH_ACCOUNT= CoryXie > +GH_TAGNAME= b1e81ec > + > +USES= gmake > + > +WRKSRC= ${WRKDIR}/DebugEdit-${GH_TAGNAME} I presume misused USE_GITHUB was already fixed earlier. > + ${INSTALL_MAN} ${WRKSRC}/README.txt ${STAGEDIR}${DOCSDIR} INSTALL_MAN is not for docs, it's for manpages. Also, when installing docs, it's a good idea to OPTIONS_DEFINE+=DOCS and use {do|post}-install-DOCS-on special helper target. > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/debugedit/files/patch-Makefile Wed Apr 12 20:49:26 2017 (r438413) > @@ -0,0 +1,12 @@ > + > +$FreeBSD$ > + > +--- Makefile.orig 2017-04-11 06:09:46 UTC > ++++ Makefile > +@@ -1,5 +1,5 @@ > + CC?=gcc > +-CFLAGS+=-lelf -lpopt -Wall > ++CFLAGS+=-lelf -lpopt -Wall -I${LOCALBASE}/include -L${LOCALBASE}/lib Have you tried to use USES+=localbase instead of patching this Makefile? > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/debugedit/pkg-plist Wed Apr 12 20:49:26 2017 (r438413) > @@ -0,0 +1,2 @@ > +bin/debugedit > +%%DOCSDIR%%/README.txt We typically discourage two-line pkg-plist files. This should've been: PLIST_FILES= bin/debugedit PORTDOCS= README.txt ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170413150057.GB86375>