From owner-svn-src-head@FreeBSD.ORG Mon Jun 23 15:52:18 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 589ACAC1; Mon, 23 Jun 2014 15:52:18 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 332252642; Mon, 23 Jun 2014 15:52:18 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D3D9DB9BD; Mon, 23 Jun 2014 11:52:16 -0400 (EDT) From: John Baldwin To: Alexander Kabaev Subject: Re: svn commit: r267762 - head/sys/dev/sound/pcm Date: Mon, 23 Jun 2014 10:15:59 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201406230345.s5N3jeiU063253@svn.freebsd.org> In-Reply-To: <201406230345.s5N3jeiU063253@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201406231015.59401.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 23 Jun 2014 11:52:16 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 15:52:18 -0000 On Sunday, June 22, 2014 11:45:40 pm Alexander Kabaev wrote: > Author: kan > Date: Mon Jun 23 03:45:39 2014 > New Revision: 267762 > URL: http://svnweb.freebsd.org/changeset/base/267762 > > Log: > Restore the check for non-NULL dmatag in sndbuf_free. > > The sound drivers that use own buffer management can use sndbuf_setup > and not do any busdma allocation, so the driver will end up with the > managed buffer but no valid dma map and tag for it. Avoid calling > bus_dmamem_free in such cases. > > Reported by: ache > Missed in review by: kan Thanks for fixing this. -- John Baldwin