Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Aug 2016 09:34:45 -0500
From:      John Marino <freebsd.contact@marino.st>
To:        Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
Subject:   Re: svn commit: r420581 - head/graphics/zathura
Message-ID:  <21a24aa6-0267-222e-e965-cf389c520642@marino.st>
In-Reply-To: <201608211945.u7LJjUAL047254@repo.freebsd.org>
References:  <201608211945.u7LJjUAL047254@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/21/2016 14:45, Kurt Jaeger wrote:
> Author: pi
> Date: Sun Aug 21 19:45:30 2016
> New Revision: 420581
> URL: https://svnweb.freebsd.org/changeset/ports/420581
>
> Log:
>   graphics/zathura: fix -x option
>
>   - fix it by adding some additional LIB_DEPENDS and a CPP flag for SYNCTEX
>
>   PR:		211468
>   Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
>   Reported by:	freebsd@schukraft.org
>   Approved by:	quentin.stievenart@gmail.com (maintainer timeout)
>
> Modified:
>   head/graphics/zathura/Makefile
>
> Modified: head/graphics/zathura/Makefile
> ==============================================================================
> --- head/graphics/zathura/Makefile	Sun Aug 21 19:39:52 2016	(r420580)
> +++ head/graphics/zathura/Makefile	Sun Aug 21 19:45:30 2016	(r420581)
> @@ -13,15 +13,21 @@ LICENSE=	ZLIB
>  LICENSE_FILE=	${WRKSRC}/LICENSE
>
>  LIB_DEPENDS=	libcairo.so:graphics/cairo \
> -		libgirara-gtk3.so:x11-toolkits/girara
> +		libgirara-gtk3.so:x11-toolkits/girara \
> +		libmagic.so:sysutils/file \
> +		libsynctex.so:devel/tex-synctex
> +
>  BUILD_DEPENDS+=	rst2html:textproc/py-docutils
>
> -USE_GNOME=	glib20 gtk30
> +USE_GNOME=	glib20 gtk30 gdkpixbuf2
>  USES=		compiler:c11 gmake pkgconfig
>  MAKE_ENV=	SFLAGS="${STRIP}" \
>  		RSTTOMAN=${LOCALBASE}/bin/rst2man \
>  		ZLIB_INC= \
> -		ZLIB_LIB=-lz
> +		ZLIB_LIB=-lz \
> +		WITH_SYNCTEX=1
> +
> +CPPFLAGS+=	-DWITH_SYNCTEX
>
>  OPTIONS_DEFINE=	NLS SQLITE
>  OPTIONS_SUB=	yes
>

I see several library dependencies added unconditionally by this change. 
  How come the PORTREVISION wasn't bumped?  It seems to me that it 
should have been.  That affects the final package significantly.

John


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21a24aa6-0267-222e-e965-cf389c520642>