From owner-svn-src-all@FreeBSD.ORG Mon Dec 6 19:53:39 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FDE5106566C; Mon, 6 Dec 2010 19:53:39 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id A4D448FC1C; Mon, 6 Dec 2010 19:53:35 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 68DBB45C98; Mon, 6 Dec 2010 20:53:34 +0100 (CET) Received: from localhost (89-73-192-49.dynamic.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 7611645C9C; Mon, 6 Dec 2010 20:53:28 +0100 (CET) Date: Mon, 6 Dec 2010 20:53:27 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20101206195327.GD1936@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SO98HVl1bnMOfKZd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 19:53:39 -0000 --SO98HVl1bnMOfKZd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 06, 2010 at 08:35:36PM +0100, Ivan Voras wrote: > Please persuade me on technical grounds why ashift, a property > intended for address alignment, should not be set in this way. If your > answer is "I don't know but you are still wrong because I say so" I > will respect it and back it out but only until I/we discuss the > question with upstream ZFS developers. No. You persuade me why changing ashift in ZFS, which, as the comment clearly states is "device's minimum transfer size" is better and not hackish than presenting the disk with properly configured sector size. This can not only affect disks that still use 512 bytes sectors, but doesn't fix the problem at all. It just works around the problem in ZFS when configured on top of raw disks. What about other file systems? What about other GEOM classes? GELI is great example here, as people use ZFS on top of GELI alot. GELI integrity verification works in a way that not reporting disk sector size properly will have huge negative performance impact. ZFS' ashift won't change that. So you should back this change out, provide technical arguments (if they exist) that this is the right solution to the problem and not "hey, here is a patch, I think it is ok". BTW. ZFS is no longer open-source if you didn't notice. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --SO98HVl1bnMOfKZd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz9PzcACgkQForvXbEpPzSEVwCfSk4NS+AaEQUew40Kmgst5AFU kCYAn2sSXQOCv87u/fEyqonUfNm4/0Uv =4zHn -----END PGP SIGNATURE----- --SO98HVl1bnMOfKZd--