From owner-svn-src-head@FreeBSD.ORG  Tue Jan  4 17:15:04 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C006C106566B
	for <svn-src-head@freebsd.org>; Tue,  4 Jan 2011 17:15:04 +0000 (UTC)
	(envelope-from julian@freebsd.org)
Received: from out-0.mx.aerioconnect.net (out-0-24.mx.aerioconnect.net
	[216.240.47.84])
	by mx1.freebsd.org (Postfix) with ESMTP id 974868FC0C
	for <svn-src-head@freebsd.org>; Tue,  4 Jan 2011 17:15:04 +0000 (UTC)
Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160])
	by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id
	p04Gxm1J018256; Tue, 4 Jan 2011 08:59:48 -0800
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org
	(h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137])
	by idiom.com (Postfix) with ESMTP id D7C5B2D6012;
	Tue,  4 Jan 2011 08:59:46 -0800 (PST)
Message-ID: <4D23521C.8020506@freebsd.org>
Date: Tue, 04 Jan 2011 09:00:12 -0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US;
	rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <201101041316.p04DGSo6037042@svn.freebsd.org>
In-Reply-To: <201101041316.p04DGSo6037042@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r216954 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2011 17:15:04 -0000

On 1/4/11 5:16 AM, John Baldwin wrote:
> Author: jhb
> Date: Tue Jan  4 13:16:28 2011
> New Revision: 216954
> URL: http://svn.freebsd.org/changeset/base/216954
>
> Log:
>    kproc_exit() is already marked __dead2 so a NOTREACHED comment here isn't
>    needed for lint.

yes but it IS good documentation when reading the code.
>
>    Submitted by:	bde
>
> Modified:
>    head/sys/kern/kern_kthread.c
>
> Modified: head/sys/kern/kern_kthread.c
> ==============================================================================
> --- head/sys/kern/kern_kthread.c	Tue Jan  4 13:02:52 2011	(r216953)
> +++ head/sys/kern/kern_kthread.c	Tue Jan  4 13:16:28 2011	(r216954)
> @@ -329,7 +329,6 @@ kthread_exit(void)
>   		PROC_UNLOCK(p);
>   		rw_wunlock(&tidhash_lock);
>   		kproc_exit(0);
> -		/* NOTREACHED */
>   	}
>   	LIST_REMOVE(curthread, td_hash);
>   	rw_wunlock(&tidhash_lock);
>