From owner-svn-src-head@freebsd.org Mon Sep 23 20:37:02 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AFD2EFF5A0 for ; Mon, 23 Sep 2019 20:37:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46cbht01Q2z4VNk for ; Mon, 23 Sep 2019 20:37:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id c3so18800215qtv.10 for ; Mon, 23 Sep 2019 13:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rPQH0VNFSUVHsql7x0KmzN6rRxdAGQXqa7ZeypQzZj4=; b=RzC62QXNJ2uNVj16LsYKY7JDutk9hz1VLKETvcozMPpNvIvRVyuQdBUAu1vPiAYnw8 GuT/5b25VNYSL3mxsPDQY0ptOOPdjcCIZrvbkGQ2A5MPP7QQJjrB3CX4g8sAkz9E+N19 NoFe5QYJu9tJYdHhfztlva5rqRiQU7jhdI6Izwvm1JIxaE+mNg1aOrRW3uoSgFqbmaOB 1tUf9v8Y2pF5lz1nPwTSKBIFbh9OZiUE9w2cRvqTFiQz41PhkTOWfH2kauGepKtlDTe+ nL8fbwBzDTJQS5DSrzFi6WfU7nqPKpki80ylkt95wew8p6x9jLFM8lE5vifMLb+8w/r5 YppA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rPQH0VNFSUVHsql7x0KmzN6rRxdAGQXqa7ZeypQzZj4=; b=hpcIbyBVp7IF2QOxZREzGv8/DkZ01kRs5fRbugQRMedCIIFHaTBwnB8ElLv6g9zkXB WGj2BPD3Pfm6S6VyNRzqm2wzgsx7sT8VujXDGlDKhqk4TFP/eSnjMATn1SatWN9IoWU/ 3SWbvwjkczwOJmWmPufRcuRdnOLrOcmwunkHd9Doc9epNvDva53vanIXk6zBy9yH05O5 LrRvXUdmlvLcsMUhPbs1oFt2zfPUmM7H9BOq5k8F+PL3HPOaE4+NftumSGoPhiF8Dum/ e7NTldoLfinyKcmPF+yNew9VyKqg6XaQ/F7AnNCqqgmDXGQx6ZayMWayG7OeFymzijL8 cAnA== X-Gm-Message-State: APjAAAXjiAPBOBR09uhvVMZjEyFzJeDt1HTL/eQka+o0FDANBVhPbBMa A9KsgeIrie5CXGe41BnpjgPeSOVefMt4qgQIjvyM/Q== X-Google-Smtp-Source: APXvYqzGMujafEu+3DuEDlBTzxmz2hl3nUKUjZXc2K3j2CYvjk4vZ7SbBbfucpZJjYyRbJU2L5FIS1RGhHj5Dl6wIhw= X-Received: by 2002:ac8:44c9:: with SMTP id b9mr2062546qto.175.1569271020959; Mon, 23 Sep 2019 13:37:00 -0700 (PDT) MIME-Version: 1.0 References: <201909231414.x8NEEh9e040728@repo.freebsd.org> <20190923190629.GD15061@raichu> <20190923202834.GE15061@raichu> In-Reply-To: <20190923202834.GE15061@raichu> From: Warner Losh Date: Mon, 23 Sep 2019 22:36:49 +0200 Message-ID: Subject: Re: svn commit: r352623 - in head/sys: amd64/amd64 kern To: Mark Johnston Cc: "Conrad E. Meyer" , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46cbht01Q2z4VNk X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=RzC62QXN; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::833) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.84 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[3.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.84)[ip: (-9.31), ipnet: 2607:f8b0::/32(-2.64), asn: 15169(-2.20), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2019 20:37:02 -0000 On Mon, Sep 23, 2019, 10:28 PM Mark Johnston wrote: > On Mon, Sep 23, 2019 at 10:13:14PM +0200, Warner Losh wrote: > > On Mon, Sep 23, 2019, 9:06 PM Mark Johnston wrote: > > > > > On Mon, Sep 23, 2019 at 11:28:52AM -0700, Conrad Meyer wrote: > > > > Hi Mark, > > > > > > > > On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston > wrote: > > > > > > > > > > Author: markj > > > > > Date: Mon Sep 23 14:14:43 2019 > > > > > New Revision: 352623 > > > > > URL: https://svnweb.freebsd.org/changeset/base/352623 > > > > > > > > > > Log: > > > > > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > > > > > > > > > This is required for DPCPU and VNET data variable definitions to > > > work when > > > > > KLDs are linked as DSOs. R_X86_64_RELATIVE relocations should > not > > > appear > > > > > in object files, so assert this in elf_relocaddr(). > > > > > > > > Is the goal to eventually link amd64 KLDs as DSOs? I might be > > > > confusing the terminology, but I believe amd64 .ko's today are > > > > unlinked ordinary object files, rather than shared objects. (I > > > > believe they use kern/link_elf_obj.c rather than kern/link_elf.c > > > > today.) > > > > > > > > If so: great! > > > > > > That's right, and that is indeed my goal. At least, I would like to > > > make the option available; with my patch set, it is possible to specify > > > the format at both the per-module and global levels. There are several > > > in-tree modules (some of the HighPoint RAID drivers, if you're curious) > > > that cannot be linked as DSOs because they contain a non-PIC blob, and > > > for now lld refuses to link them into a DSO. > > > > > > > That problem might be better solved by removing the highpount driver > since > > they are old and abandon ware these days. I'm serious here, old stuff > with > > low value getting in the way might be better off in our rearview > mirror... > > Well, there are at least four drivers. I'm not sure which, if any, are > actively used these days, though some of them have gotten vendor updates > in the past several years. In any case, handling the issue involved > adding a single line to each driver's makefile, so I don't feel too > oppressed. > At least 3 of the 4 are so old as to be irrelevant by any standard... and the 4th is teetering on the edge as well. Warner >