From owner-p4-projects@FreeBSD.ORG  Thu Jun  4 20:30:08 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8A6E21065675; Thu,  4 Jun 2009 20:30:08 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4A590106564A
	for <perforce@freebsd.org>; Thu,  4 Jun 2009 20:30:08 +0000 (UTC)
	(envelope-from zec@fer.hr)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 383558FC16
	for <perforce@freebsd.org>; Thu,  4 Jun 2009 20:30:08 +0000 (UTC)
	(envelope-from zec@fer.hr)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n54KU8TK033258
	for <perforce@freebsd.org>; Thu, 4 Jun 2009 20:30:08 GMT
	(envelope-from zec@fer.hr)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n54KU8PH033256
	for perforce@freebsd.org; Thu, 4 Jun 2009 20:30:08 GMT
	(envelope-from zec@fer.hr)
Date: Thu, 4 Jun 2009 20:30:08 GMT
Message-Id: <200906042030.n54KU8PH033256@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@fer.hr using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 163520 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2009 20:30:10 -0000

http://perforce.freebsd.org/chv.cgi?CH=163520

Change 163520 by zec@zec_amdx4 on 2009/06/04 20:29:14

	Trim comments.

Affected files ...

.. //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#50 edit

Differences ...

==== //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#50 (text+ko) ====

@@ -660,9 +660,8 @@
 }
 
 /*
- * Destroy a vnet - unlink all linked lists, free all the memory, stop all
- * the timers... How can one ever be sure to have done *all* the necessary
- * steps?
+ * Destroy a vnet - unlink all linked lists, hashtables etc., free all
+ * the memory, stop all the timers...
  */
 static int
 vi_destroy(struct vimage *vip)
@@ -687,11 +686,8 @@
 		    vip->vi_name, vip->vi_ucredrefc);
 
 	/* Point with no return - cleanup MUST succeed! */
-	/* XXX locking */
 	LIST_REMOVE(vip, vi_le);
 	LIST_REMOVE(vip, vi_sibling);
-
-	/* XXX locking */
 	LIST_REMOVE(vprocg, vprocg_le);
 
 	VNET_LIST_WLOCK();
@@ -701,10 +697,7 @@
 	CURVNET_SET_QUIET(vnet);
 	INIT_VNET_NET(vnet);
 
-	/*
-	 * Return all inherited interfaces to their parent vnets,
-	 * alternatively attempt to kill cloning ifnets.
-	 */
+	/* Return all inherited interfaces to their parent vnets. */
 	TAILQ_FOREACH_SAFE(ifp, &V_ifnet, if_link, nifp) {
 		if (ifp->if_home_vnet != ifp->if_vnet)
 			vi_if_move(NULL, ifp, vip);
@@ -717,7 +710,7 @@
 
 	CURVNET_RESTORE();
 
-	/* hopefully, we are finally OK to free the vnet container itself! */
+	/* Hopefully, we are OK to free the vnet container itself. */
 	vnet->vnet_magic_n = 0xdeadbeef;
 	free(vnet, M_VNET);
 	free(vprocg, M_VPROCG);