From owner-freebsd-firewire@FreeBSD.ORG Fri Dec 21 01:16:37 2007 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D328C16A46C; Fri, 21 Dec 2007 01:16:37 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from plato.miralink.com (mail.miralink.com [70.103.185.20]) by mx1.freebsd.org (Postfix) with ESMTP id AA18013C4CE; Fri, 21 Dec 2007 01:16:37 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by plato.miralink.com (Postfix) with ESMTP id 3A7931C81D9; Thu, 20 Dec 2007 17:16:37 -0800 (PST) Received: from plato.miralink.com ([127.0.0.1]) by localhost (plato.miralink.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 22249-01; Thu, 20 Dec 2007 17:16:36 -0800 (PST) Received: from iago.office.miralink.com (iago.office.miralink.com [10.0.0.40]) by plato.miralink.com (Postfix) with ESMTP id 52CA91C81CD; Thu, 20 Dec 2007 17:16:36 -0800 (PST) Message-ID: <476B13F4.5050409@miralink.com> Date: Thu, 20 Dec 2007 17:16:36 -0800 From: Sean Bruno User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Hidetoshi Shimokawa References: <476610E5.2060108@miralink.com> <626eb4530712162258s4dfe1448o1102f20a623d3f95@mail.gmail.com> <476696C4.60408@miralink.com> <626eb4530712182320q237c344crd309893a82fe8ef8@mail.gmail.com> In-Reply-To: <626eb4530712182320q237c344crd309893a82fe8ef8@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Thu Dec 20 17:16:36 2007 X-DSPAM-Confidence: 0.9997 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 476b13f4230907852419847 X-DSPAM-Factors: 27, X-Virus-Scanned: amavisd-new at X-Spam-Status: No, score=-4.468 tagged_above=-10 required=6.6 autolearn=ham tests=[ALL_TRUSTED=-1.8, AWL=0.031, BAYES_00=-2.599, DSPAM_HAM=-0.1] X-Spam-Score: -4.468 X-Spam-Level: Cc: freebsd-firewire@freebsd.org Subject: Re: sbp_targ memory leak X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2007 01:16:37 -0000 Hidetoshi Shimokawa wrote: > I think you are right and page table is not freed when CAM_SEND_STATUS > is not set. > Maybe we should always free page tables if refcont == 0 rather than > free in sbp_targ_send_status(). > > You patch is not just adding debug printfs, right? > What is the mtx locks for? > > On 12/18/07, Sean Bruno wrote: > >> Hidetoshi Shimokawa wrote: >> >>> Thanks for the tracking of the problem. >>> Could you resend the patch in unified or context diff? >>> >>> Thanks, >>> >>> On 12/17/07, Sean Bruno wrote: >>> >>> >>>> In trying to understand and make sbp_targ functional, I've noted that >>>> the code seems to lose track of how many page tables it allocates for >>>> any give orbi. I had to add a lot of debugging code around the >>>> malloc/free's to find out what was going on, and I'm not sure what the >>>> code is supposed to do in this case. >>>> >>>> Please review the patch diff at --> http://consultcsg.com/RELENG_6.diff >>>> >>>> And the log at -->http://consultcsg.com/malloc_failure.txt >>>> >>>> >>>> >>>> >> Diff updated at http://consultcsg.com/RELENG_6.diff >> >> Sean >> >> I moved the free around as you suggested and the memory leak does indeed go away and there are no further crashes. Here is my current diff --> http://consultcsg.com/RELENG_6.diff . It does look like the data is not being written or read to the backend correctly however. I.e. the page_table is not being setup correctly when more than one read or write is required to service an ORB. Any ideas on how to look into that? Sean