Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Dec 2018 13:32:51 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r341633 - stable/10/sys/security/audit
Message-ID:  <201812061332.wB6DWphp031484@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Thu Dec  6 13:32:51 2018
New Revision: 341633
URL: https://svnweb.freebsd.org/changeset/base/341633

Log:
  MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
  
  PR:		229983

Modified:
  stable/10/sys/security/audit/audit_pipe.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/security/audit/audit_pipe.c
==============================================================================
--- stable/10/sys/security/audit/audit_pipe.c	Thu Dec  6 12:34:34 2018	(r341632)
+++ stable/10/sys/security/audit/audit_pipe.c	Thu Dec  6 13:32:51 2018	(r341633)
@@ -800,7 +800,7 @@ audit_pipe_ioctl(struct cdev *dev, u_long cmd, caddr_t
 
 	case AUDITPIPE_SET_QLIMIT:
 		/* Lockless integer write. */
-		if (*(u_int *)data >= AUDIT_PIPE_QLIMIT_MIN ||
+		if (*(u_int *)data >= AUDIT_PIPE_QLIMIT_MIN &&
 		    *(u_int *)data <= AUDIT_PIPE_QLIMIT_MAX) {
 			ap->ap_qlimit = *(u_int *)data;
 			error = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812061332.wB6DWphp031484>