From owner-cvs-sys Fri Sep 15 10:11:20 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA23612 for cvs-sys-outgoing; Fri, 15 Sep 1995 10:11:20 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id KAA23589 ; Fri, 15 Sep 1995 10:11:06 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id DAA19915; Sat, 16 Sep 1995 03:06:52 +1000 Date: Sat, 16 Sep 1995 03:06:52 +1000 From: Bruce Evans Message-Id: <199509151706.DAA19915@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, ats@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa wcd.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk > Modified: sys/i386/isa wcd.c > Log: > Correct the calculation of the unit number. it is not minor(x) & 3. It need > to be shifted >> 3. The last bits are the partition info. The dkunit() macro gives the correct formula. The partition bits should be decoded to avoid aliasing bugs. This is most easily done by calling dsopen() and dsclose(). There should be a new flag to dsopen() to tell it not to look for an MBR. Bruce