From owner-freebsd-current@FreeBSD.ORG  Tue May 19 19:10:24 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9BDA4F30
 for <current@freebsd.org>; Tue, 19 May 2015 19:10:24 +0000 (UTC)
Received: from outbound3.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119]) by mx1.freebsd.org (Postfix) with SMTP id 79C7917F8
 for <current@freebsd.org>; Tue, 19 May 2015 19:10:24 +0000 (UTC)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Tue, 19 May 2015 19:10:06 +0000 (UTC)
Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id t4JJAG0l017360;
 Tue, 19 May 2015 13:10:17 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1432062616.1573.6.camel@freebsd.org>
Subject: Re: pedantic compiler warnings: double semicolons, function to data
 pointers
From: Ian Lepore <ian@freebsd.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: Luigi Rizzo <rizzo@iet.unipi.it>, "current@freebsd.org"
 <current@freebsd.org>
Date: Tue, 19 May 2015 13:10:16 -0600
In-Reply-To: <CAJ-Vmom3Tmev=GfCLA9Nzf-tChXaPcDtne8B9Nk9jNY-Nc4vMw@mail.gmail.com>
References: <20150519184252.GB66725@onelab2.iet.unipi.it>
 <CAJ-Vmom3Tmev=GfCLA9Nzf-tChXaPcDtne8B9Nk9jNY-Nc4vMw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 19:10:24 -0000

On Tue, 2015-05-19 at 11:56 -0700, Adrian Chadd wrote:
> On 19 May 2015 at 11:42, Luigi Rizzo <rizzo@iet.unipi.it> wrote:
> > While trying to compile some of my (kernel) code in different environments,
> > i noticed a couple of errors that perhaps might be worth fixing
> >
> > - extra semicolons. These come either from explicit repetitions in the code
> >   (see the output of a grep at the end of this message),
> >   or sometimes from the epansion of macros such as BITSET_DEFINE()
> 
> I think removing double-semicolons isn't a bad task..

As long as whoever does it also MFCs it so that it isn't just a bunch of
lurking merge conflicts in the future.

-- Ian