Date: Sun, 16 Feb 2003 03:10:27 -0800 (PST) From: Dag-Erling Smorgrav <des@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 25271 for review Message-ID: <200302161110.h1GBAR3U001313@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=25271 Change 25271 by des@des.at.des.thinksec.com on 2003/02/16 03:09:51 Avoid a NULL pointer dereference if PAM_CONV is non-NULL but its conv member is NULL. Affected files ... .. //depot/projects/openpam/lib/pam_vprompt.c#9 edit Differences ... ==== //depot/projects/openpam/lib/pam_vprompt.c#9 (text+ko) ==== @@ -31,7 +31,7 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $P4: //depot/projects/openpam/lib/pam_vprompt.c#8 $ + * $P4: //depot/projects/openpam/lib/pam_vprompt.c#9 $ */ #include <stdarg.h> @@ -66,7 +66,7 @@ r = pam_get_item(pamh, PAM_CONV, (const void **)&conv); if (r != PAM_SUCCESS) RETURNC(r); - if (conv == NULL) { + if (conv == NULL || conv->conv == NULL) { openpam_log(PAM_LOG_ERROR, "no conversation function"); RETURNC(PAM_SYSTEM_ERR); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302161110.h1GBAR3U001313>