From owner-p4-projects@FreeBSD.ORG  Mon May 17 13:58:25 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A6FAE16A4D0; Mon, 17 May 2004 13:58:25 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 754AB16A4CE
	for <perforce@freebsd.org>; Mon, 17 May 2004 13:58:25 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 305C743D41
	for <perforce@freebsd.org>; Mon, 17 May 2004 13:58:25 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i4HKwOGe066901
	for <perforce@freebsd.org>; Mon, 17 May 2004 13:58:24 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i4HKwOR5066898
	for perforce@freebsd.org; Mon, 17 May 2004 13:58:24 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Date: Mon, 17 May 2004 13:58:24 -0700 (PDT)
Message-Id: <200405172058.i4HKwOR5066898@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 52947 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2004 20:58:26 -0000

http://perforce.freebsd.org/chv.cgi?CH=52947

Change 52947 by peter@peter_hammer on 2004/05/17 13:58:08

	Fix refcount "bug".  If you have two loaders in a kernel, one has
	a kobj class refcount for the "kernel", the other has 0 refs.
	When you load/unload on the "other" loader, the refcount goes
	0->1->0.  And then kobj helpfully frees the compiled method table.
	
	Cheat, and fight fire with fire.  Since we can't ever unload
	classes, add a manual refcount boost to prevent this happening.

Affected files ...

.. //depot/projects/hammer/sys/kern/kern_linker.c#14 edit

Differences ...

==== //depot/projects/hammer/sys/kern/kern_linker.c#14 (text+ko) ====

@@ -148,6 +148,7 @@
 	if (linker_no_more_classes == 1)
 		return (EPERM);
 	kobj_class_compile((kobj_class_t) lc);
+	((kobj_class_t)lc)->refs++;	/* prevent ops being freed */
 	TAILQ_INSERT_TAIL(&classes, lc, link);
 	return (0);
 }