From owner-freebsd-net@FreeBSD.ORG Fri Jul 18 11:23:28 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59AB51065675 for ; Fri, 18 Jul 2008 11:23:28 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.228]) by mx1.freebsd.org (Postfix) with ESMTP id 1CBEB8FC13 for ; Fri, 18 Jul 2008 11:23:28 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so346476rvf.43 for ; Fri, 18 Jul 2008 04:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=95ZibD323pHnmdtc18lUz4wS5m/D2B8OlrHsw06e6nA=; b=nE8qhQHaLf3Zs8Zl6bRnXSaE/Ey5T9DWqPYsaNu0donRqfLdbChFbekvh1vG+w3lSe wVwuRr+aTcBKSwcGBD3563GCAciHjbQ8tkj1BPuv+HVho3qiYrTy1ZlHi3I5toKM+4iP S5q3uSQbTH03iO7013kJGNJVm6b5t6NTb2v6w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=TTDOX1DotgD0/ZZJwUHF9Ew28cA3icYcZ8cvocQWwcqhiDTQGvALI5EJfNowLPr/SM b/AxuN6fSoP167TrAmhtK3pmLK0LkU9kp36vANtkV6hrgaKO6tvO1256VaRPTfnU4q03 8zhW1nSarR71Xw/7Mc27yojEAegxZNxM12SAs= Received: by 10.141.89.13 with SMTP id r13mr1820361rvl.88.1216378697407; Fri, 18 Jul 2008 03:58:17 -0700 (PDT) Received: by 10.141.86.19 with HTTP; Fri, 18 Jul 2008 03:58:17 -0700 (PDT) Message-ID: <3a142e750807180358i4e3baa3m9ebe7cad357fe2cf@mail.gmail.com> Date: Fri, 18 Jul 2008 12:58:17 +0200 From: "Paul B. Mahol" To: "Andrew Thompson" In-Reply-To: <200807171650.m6HGo4aK018239@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200807171650.m6HGo4aK018239@freefall.freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: kern/125181: [ndis] [patch] with wep enters kdb.enter.unknown, panics X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2008 11:23:28 -0000 On 7/17/08, Andrew Thompson wrote: > The following reply was made to PR kern/125181; it has been noted by GNATS. > > From: Andrew Thompson > To: Coleman Kane > Cc: bug-followup@FreeBSD.org, onemda@gmail.com > Subject: Re: kern/125181: [ndis] [patch] with wep enters kdb.enter.unknown, > panics > Date: Thu, 17 Jul 2008 09:43:42 -0700 > > On Thu, Jul 17, 2008 at 12:09:52PM -0400, Coleman Kane wrote: > > Andrew, > > > > I got directed to this PR by onemda@gmail.com (Paul D. Mahol), who's > > been helping me track down some edge cases in the if_ndis locking > > rewrite. I am not 100% familiar with the locking semantics in play here > > (IEEE80211 and VAPs), so I wanted to run it by you before I determine > > that it seems to be working well for me. > > I dont think ndis should be reaching into the net80211 lock. Now that > ndis uses a regular mutex its a good chance to add mtx_asserts in the > right places and get the locking up to speed. I will try to post a patch > soon unless someone beats be to it. Patch impact on performance is marginal if not completely irrelevant. The only way to improve code in that file is rewritting offending functions. And at end net80211 lock would be still there (called via some other function).