From owner-freebsd-commit Thu Dec 14 07:02:25 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA06357 for freebsd-commit-outgoing; Thu, 14 Dec 1995 07:02:25 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA06099 for cvs-all-outgoing; Thu, 14 Dec 1995 06:59:36 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA06088 for cvs-sys-outgoing; Thu, 14 Dec 1995 06:59:33 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id GAA06074 Thu, 14 Dec 1995 06:59:20 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id BAA18909; Fri, 15 Dec 1995 01:55:36 +1100 Date: Fri, 15 Dec 1995 01:55:36 +1100 From: Bruce Evans Message-Id: <199512141455.BAA18909@godzilla.zeta.org.au> To: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, peter@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci bt9xx.c Sender: owner-commit@FreeBSD.ORG Precedence: bulk > Change the generic "btintr" function's name to "bt_intr" - the same as > all the other bt_XXX() functions in i386/scsi/bt*. > > This the important effect of forcing a link error if the user is > still using the old "vector btintr" which is dangerously wrong > after Justin's updates to the driver. > > The correct isa vector line for the bt driver is "vector bt_isa_intr". > Justin mentioned this in the commit message and updated LINT and > GENERIC. This change is to enforce that.. :-) I think btintr should have been left as btintr so that old config files don't need to be changed. Only config [-n :-] needs to be run. Can we agree on a naming scheme for drivers? I'd like all routines in module xxx to begin with "xxx" (not "xxx_", unless one is used for functions and the other for variables). Bruce