Date: Thu, 15 Jun 2017 00:55:15 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Tobias C. Berner" <tcberner@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443599 - head/Mk Message-ID: <20170615005515.GA26393@FreeBSD.org> In-Reply-To: <201706142018.v5EKIc8G062340@repo.freebsd.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 14, 2017 at 08:18:38PM +0000, Tobias C. Berner wrote: > New Revision: 443599 > URL: https://svnweb.freebsd.org/changeset/ports/443599 > > Log: > Add note, that WRKDIRPREFIX must not end in '/'. > > PR: 199297 This is stupid, fragile, error-prone appoach that does not even cover all cases (like shown in the PR) when no paths end in slash but the problem still occurs. Did you read the analysis of my original problem carefully enough? It was not about slashes, it was symlinks and realpath. You might not like proposed solution but then think of something better; computers are smart enough to handle slashes automagically rather than depend on that unrealiable human beings will follow the rules and notes. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170615005515.GA26393>