From owner-svn-src-projects@FreeBSD.ORG Mon Sep 7 19:46:52 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD7BC106568B; Mon, 7 Sep 2009 19:46:52 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 7E4128FC16; Mon, 7 Sep 2009 19:46:52 +0000 (UTC) Received: from [192.168.133.14] (nat2-102.ghnet.pl [91.150.223.102]) by smtp.semihalf.com (Postfix) with ESMTPSA id 76E58C4278; Mon, 7 Sep 2009 21:45:22 +0200 (CEST) Message-Id: <759008C0-032F-425F-A9CD-E9149763273C@semihalf.com> From: Rafal Jaworowski To: Nathan Whitehorn In-Reply-To: <4AA5601D.9040004@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Mon, 7 Sep 2009 21:46:50 +0200 References: <200909071901.n87J1Yn7023803@svn.freebsd.org> <4AA5601D.9040004@freebsd.org> X-Mailer: Apple Mail (2.936) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196945 - projects/ppc64/sys/boot/common X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2009 19:46:52 -0000 On 2009-09-07, at 21:33, Nathan Whitehorn wrote: > Rafal Jaworowski wrote: >> >> On 2009-09-07, at 21:01, Nathan Whitehorn wrote: >> >>> Author: nwhitehorn >>> Date: Mon Sep 7 19:01:34 2009 >>> New Revision: 196945 >>> URL: http://svn.freebsd.org/changeset/base/196945 >>> >>> Log: >>> r60506 broke netbooting on PowerPC/OFW completely. We need a way of >>> reverting this in a way that doesn't break Book-E. >>> >>> Modified: >>> projects/ppc64/sys/boot/common/dev_net.c >>> >>> Modified: projects/ppc64/sys/boot/common/dev_net.c >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- projects/ppc64/sys/boot/common/dev_net.c Mon Sep 7 >>> 18:54:55 2009 (r196944) >>> +++ projects/ppc64/sys/boot/common/dev_net.c Mon Sep 7 >>> 19:01:34 2009 (r196945) >>> @@ -145,7 +145,7 @@ net_open(struct open_file *f, ...) >>> return (error); >>> } >>> } >>> -#if defined(__sparc64__) >>> +#if defined(__sparc64__) || defined(__powerpc__) >>> netdev_opens++; >>> #endif >>> } >> >> In general it's not a Book-E thing at all. It's clearly a bug not >> to update the open counter (with the above change the loader will >> not reach netif_close(), which is bad); I know some firmware >> versions have had problems here, that lead to unresponsiveness or >> so, but it shouldn't really depend on powerpc/sparc64 define: it's >> rather a broken firmware/platform thing and should be handled as a >> platform workaround (build option?), not something arch-related. >> >> Rafal >> > True. Basically, we should never try to reopen the net device on > Open Firmware platforms. Maybe a new define so that the common > loader code can check for OF? This firmware bug is *very* prevalent > on Apple hardware. > -Nathan It would be ideal to push this workaround down to the Open Firmware netif_init() routine, so that it would ignore re-opening (and not pollute common loader code). Wouldn't this work? Rafal