From owner-freebsd-stable@FreeBSD.ORG Wed Jul 30 11:30:36 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 080C31065671 for ; Wed, 30 Jul 2008 11:30:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 8065D8FC1B for ; Wed, 30 Jul 2008 11:30:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m6UBUV9L094124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Jul 2008 14:30:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m6UBUVGJ017137; Wed, 30 Jul 2008 14:30:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m6UBUV2P017136; Wed, 30 Jul 2008 14:30:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 30 Jul 2008 14:30:31 +0300 From: Kostik Belousov To: Heiko Wundram Message-ID: <20080730113031.GS97161@deviant.kiev.zoral.com.ua> References: <1217346345.12322.31.camel@bauer.cse.buffalo.edu> <200807301302.52450.modelnine@modelnine.org> <200807301326.33227.modelnine@modelnine.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dx1O6sYEs5STvSrm" Content-Disposition: inline In-Reply-To: <200807301326.33227.modelnine@modelnine.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-stable@freebsd.org Subject: Re: Upcoming ABI Breakage in RELENG_7 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2008 11:30:36 -0000 --Dx1O6sYEs5STvSrm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 30, 2008 at 01:26:33PM +0200, Heiko Wundram wrote: > Am Mittwoch, 30. Juli 2008 13:03:34 schrieb Ronald Klop: > > I think in this case (the ABI breakage) it is more nice to say: "If you > > don't know what to do, you wil probably not see any problem because of > > this." > > The edge case of what can go wrong is so small, that you must be doing > > quite specialized stuff to see breakage. In that case you would underst= and > > what is going on. (IMHO) >=20 > Err, no. >=20 > As someone else has already noted, a prominent KLM that's distributed=20 > separately from the kernel which uses the vnode structure extensively (wh= ich=20 > I didn't think of at all until I read the respective mail) is fuse. A=20 > pre-upgrade compiled fuse is most certainly going to break because of thi= s=20 > change. Some people have dual installations of Windows/FreeBSD (at least = I'd=20 > presume that's the case with the fiddlers like me that track -STABLE as a= =20 > hobby, not as a developer, or those developers who program for Windows as= a=20 > day-job, also like me) who use ntfs-3g to mount their NTFS-data;=20 > additionally, I also extensively use ssh-fs, which is also fuse-based, an= d I=20 > guess there are also others who use it, and so the reach of this ABI-chan= ge,=20 > at least IMHO, is much larger than the original message makes you believe. >=20 > Now, after the update, a lot can go wrong, because the fuse KLM is loaded= by=20 > an init-script, and your system is most probably going to Oops while boot= ing=20 > if you didn't think of disabling the fuse init-script before you update y= our=20 > kernel, and will NOT fail "gracefully". If the respective person doesn't = know=20 > how he/she should boot to single-user-mode, update rc.conf to disable thi= s,=20 > reboot, rebuild the module to get the system back up, the only thing I ca= n=20 > possibly say is: "don't track stable." >=20 > It might've sounded a bit harsh what I wrote, but tracking -STABLE means= =20 > knowing your system enough so that you know how to fix things if they com= e=20 > back to bite you (especially after getting a HEADS UP). And that doesn't = seem=20 > to be the case here if the respective person asks for SPECIFIC instructio= ns=20 > what to do. >=20 > So, again: DON'T track -STABLE if you can't fix the system if it breaks, = and=20 > AFAICT this change is most certainly going to break quite a few systems. I do not use the fuse fs myself. But the issue was raised during the internal discussion of the MFC, and it seems that fuse could be not affected. The change only adds the field at the end of the vnode structure, so all existing fields offsets are intact. --Dx1O6sYEs5STvSrm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkiQUNYACgkQC3+MBN1Mb4hJVgCgrOIoA44UuxdRneRX/MLiX7dB RBgAoL6NH0LCWyIRbmusyI7GLrnXg76p =WTkT -----END PGP SIGNATURE----- --Dx1O6sYEs5STvSrm--