From owner-svn-src-head@FreeBSD.ORG Tue Jun 24 04:29:13 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 19C16400; Tue, 24 Jun 2014 04:29:13 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA7EF2A22; Tue, 24 Jun 2014 04:29:11 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id DD4351FE028; Tue, 24 Jun 2014 06:28:59 +0200 (CEST) Message-ID: <53A8FEA3.4020804@selasky.org> Date: Tue, 24 Jun 2014 06:29:23 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: John Baldwin , Alexander Kabaev Subject: Re: svn commit: r267762 - head/sys/dev/sound/pcm References: <201406230345.s5N3jeiU063253@svn.freebsd.org> <201406231015.59401.jhb@freebsd.org> In-Reply-To: <201406231015.59401.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 04:29:13 -0000 On 06/23/14 16:15, John Baldwin wrote: > On Sunday, June 22, 2014 11:45:40 pm Alexander Kabaev wrote: >> Author: kan >> Date: Mon Jun 23 03:45:39 2014 >> New Revision: 267762 >> URL: http://svnweb.freebsd.org/changeset/base/267762 >> >> Log: >> Restore the check for non-NULL dmatag in sndbuf_free. >> >> The sound drivers that use own buffer management can use sndbuf_setup >> and not do any busdma allocation, so the driver will end up with the >> managed buffer but no valid dma map and tag for it. Avoid calling >> bus_dmamem_free in such cases. >> >> Reported by: ache >> Missed in review by: kan > > Thanks for fixing this. > Excellent! --HPS