From owner-svn-src-all@freebsd.org Fri Apr 15 15:45:19 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C14A5AEDCCD for ; Fri, 15 Apr 2016 15:45:19 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8777A1214 for ; Fri, 15 Apr 2016 15:45:19 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mail-ig0-x235.google.com with SMTP id g8so26137165igr.0 for ; Fri, 15 Apr 2016 08:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:subject:mime-version:from:in-reply-to:date:cc:message-id :references:to; bh=Pg8Vhqa5rMnvRl1uMncOT9C3uXJ77UePpcGZJvJnjCM=; b=xQDXvnDPWX7SUwlZ2RbZUATrYgBtODbC6ZkWUvmtKb6L2lhoRcbSuAUB6fPFq2dBt6 TEGqvdftwIYzDe3Q57K727XOXnmOPKiT9pDST/7xC+k+K/pgGBWOWkKnIWtMsHQKu7eT YixeGB+5DHQUE4FJV/vGhY3bdwW26V9/XTRJiLAic8R27UuSe4IihCziN3YF/8dXtjmW +RQz3ZF8PNHnjiNYQr32oana7rXXcgaeCT3Vwyl56/aFWfeXPsoG1dXhCxHyDPZMdK06 1xUrobNHa4Jr5NDAFf2mre6/fAsMvoVqzCGxmtvNQpyczMuuLi7RHW5Oboz1zZMcd+Xe ik+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:from:in-reply-to :date:cc:message-id:references:to; bh=Pg8Vhqa5rMnvRl1uMncOT9C3uXJ77UePpcGZJvJnjCM=; b=TzUC16Gp5UGPR9Dze8rh8CiSSYH03MwmrLDjhe1hParbbjPy5KkVaXe2zlQsS3fziE YOVPFBlPWIT1cxHxo8g7wIUAlrICyP0/2t6whmHb9oQHz7DQWBJfbmvGCy24Cdn6W3Zq oLEGGilZESf2bdm8bGQlECeUouWlH3Oj619kHbpbhbrdkX/vPqCfNQ0Zr3oNhkIKnTXr vpTcTF/RBAxm28ANgyOgUjwq0zmMJpChma6CiNyryf4yogWomzmAFOx9ShPA1tA208Ai FPeHsw4K/93nf62ieqh1ArDRef9KVO6awDjMFLLgcoEBADxRtyIONNDFtl1qE7HDS+rW HPUQ== X-Gm-Message-State: AOPr4FWjaJ6DAQyIwy58L8st1jp/so2LTReFIMAXAik6jgz7VwlkAf9PAKPG2KEjGvtA6A== X-Received: by 10.50.160.39 with SMTP id xh7mr5519842igb.64.1460735118786; Fri, 15 Apr 2016 08:45:18 -0700 (PDT) Received: from mac.nflx.bsdimp.com ([50.253.99.174]) by smtp.gmail.com with ESMTPSA id su5sm24420848igc.21.2016.04.15.08.45.17 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Apr 2016 08:45:18 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r298011 - head/sys/cam/ata Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E2456E4E-8728-4BE0-9560-AA8D43184A24"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: Date: Fri, 15 Apr 2016 09:45:16 -0600 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Warner Losh Message-Id: <65ACB63B-ACDF-4552-BDA9-40FB028EB0D6@bsdimp.com> References: <201604142213.u3EMDklN061064@repo.freebsd.org> To: Ronald Klop X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 15:45:19 -0000 --Apple-Mail=_E2456E4E-8728-4BE0-9560-AA8D43184A24 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii A shorter timeout dramatically cuts the length of time that the queue has to be frozen for error recovery. This allows one, in theory, to recover the system more quickly after a drive goes off into the weeds. Warner > On Apr 15, 2016, at 9:23 AM, Ronald Klop wrote: >=20 > Hello, >=20 > Out of curiosity, what are these big problems? Broken device or other = things (timeouts/triggers/full queues) going on in the kernel? >=20 > Regards, > Ronald. >=20 >=20 > On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh = wrote: >=20 >> Author: imp >> Date: Thu Apr 14 22:13:46 2016 >> New Revision: 298011 >> URL: https://svnweb.freebsd.org/changeset/base/298011 >> erLog: >> Add a comment about why the timeout for flush was lowered to 5s. >>=20 >> Modified: >> head/sys/cam/ata/ata_da.c >>=20 >> Modified: head/sys/cam/ata/ata_da.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:44 2016 = (r298010) >> +++ head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:46 2016 = (r298011) >> @@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off >> if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) { >> xpt_setup_ccb(&ccb.ccb_h, periph->path, = CAM_PRIORITY_NORMAL); >> + /* >> + * Tell the drive to flush its intenral cache. if we >> + * can't flush in 5s we have big problems. No need to >> + * wait the default 60s to detect problems. >> + */ >> ccb.ccb_h.ccb_state =3D ADA_CCB_DUMP; >> cam_fill_ataio(&ccb.ataio, >> 0, >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to = "svn-src-all-unsubscribe@freebsd.org" --Apple-Mail=_E2456E4E-8728-4BE0-9560-AA8D43184A24 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXEQyMAAoJEGwc0Sh9sBEAsbkQANpylhiE/565ZjJsLYFvkH+G 6ZFGLZdWnFwcEltmEEdJU6McL+iX8/PCwwn8P3wL3RxNg+Cvw5Xnx04JMwnJArfI PtXKxqGuyIdMyTXbp6QjQHWhX175J4Lo7T52qQJ0HIjftTYpZiPj+aopWqwsrBmN REZFc3vLQ0VICCm4SmmgkYXsc6djQHzhdEsTC+Xav2IoS8wajny1WTCHQhzqIUTw 3a3/hti15Q725mo1lzwOHzvo2Jgmv1gQyFRORkBQpDd37h5Ies0i/eQ/fijUBxSR VKlgQTj7hYz9W0sLveVV54DUF4KQuIMHE9XEbtf68nSrzgobay6qDo8BCl7atORy ziS6uEqFoB7C0B9oLHbst53btQnm8KoBsJvJm4zBNjXV+CRkkU9hWLB9dEwMhdON IRJx3G7KbgBzq2jKoF8bmZP3d8CgBjonicm/UKyXAuxg6Gjwn0IWKCpnF9WUC+2D AuSaCccPOVZ1AmgvxAstD3wfMrUkQZrUN/Y5fwklWcCXwVNqYo7fqs7OfyRcpDGq AyCgARpUDa7DKooBiu4eQiTJDDAfvusNBFlpbw35ireU1EOQiG8VFXALP9t63/39 5Hr1NXkgGfshYfwn+5J4Wn8KaDpOuL0KZm4wqLqe+lBID0bjrI1M6doGyCooWMOf 4HRueGtR9oXnCw8wjZl4 =nbV/ -----END PGP SIGNATURE----- --Apple-Mail=_E2456E4E-8728-4BE0-9560-AA8D43184A24--