From owner-freebsd-net@FreeBSD.ORG Tue Dec 27 10:56:17 2011 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A43A1065672; Tue, 27 Dec 2011 10:56:17 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0C9608FC14; Tue, 27 Dec 2011 10:56:16 +0000 (UTC) Received: by iadj38 with SMTP id j38so24563855iad.13 for ; Tue, 27 Dec 2011 02:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=xdWiVtPOgn90G+xchC9rKyAaDyfjLswj4XHMnbejq68=; b=mNCVkJ3hwUHad7tyviufMx7C6IV+rD+EXgm2OYBxWn/N+9dKkQuXTQ3DM3Ov0tiw0I ddoipoxRBy71GTjSgEkG24T7gQaN6jVJxCmY4LSS2aFoWG9HWVpNcccUvywnz3cBOLHI RJZPZeDQBIGNPdMECmqywd7lcaAxVTeuTYiPg= MIME-Version: 1.0 Received: by 10.50.195.164 with SMTP id if4mr30323076igc.11.1324981742631; Tue, 27 Dec 2011 02:29:02 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.231.183.76 with HTTP; Tue, 27 Dec 2011 02:29:02 -0800 (PST) In-Reply-To: <20111227041728.GI8035@FreeBSD.org> References: <201112221130.01823.jhb@freebsd.org> <20111227041728.GI8035@FreeBSD.org> Date: Tue, 27 Dec 2011 11:29:02 +0100 X-Google-Sender-Auth: rJv_TloSuegnQTrHb0NZ38hsTjA Message-ID: From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: Robert Watson , John Baldwin , net@freebsd.org Subject: Re: Transitioning if_addr_lock to an rwlock X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 10:56:17 -0000 2011/12/27 Gleb Smirnoff : > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: > J> You can find the patch for 8.x at > J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch > > Just my two pennies: for head/ patching if ip_carp.c should > be straightforward: > > 1) Using W in carp_alloc_if() and carp_free_if(). > 2) Using R everywhere else. > I would not say that is true! Look at this https://github.com/bsdperimeter/pfsense-tools/blob/master/patches/RELENG_8_1/carp_livelock_fixes.diff I already did this for carp on pfSense for 8.x and should be the same for HEAD. That has undergone testing and catching up where R vs W. > -- > Totus tuus, Glebius. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" -- Ermal