From owner-freebsd-doc@FreeBSD.ORG Sat Dec 8 22:04:46 2012 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E91DBE9 for ; Sat, 8 Dec 2012 22:04:46 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id E431C8FC15 for ; Sat, 8 Dec 2012 22:04:45 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so1472311lah.13 for ; Sat, 08 Dec 2012 14:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=DHHv7Rqhc+PkxV6yni+eYCbdaNBpW2EcTxrkpc4w2l0=; b=T2eEwwOfLDMaNcgEzFXbNh0ZCSlJMydqk/0Z+icGyy+UxpGGruD0KoM+pRhrnGbDqD Trx5uUwXZi4mXh57xpg6O6YUUTX4BMmkeascnQA22raO2KM9oIvF6YjiRN2wZNE+/ns4 qGTk4TfEawhWB/RcGKqPGD44vuG2f7eDUR8oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=DHHv7Rqhc+PkxV6yni+eYCbdaNBpW2EcTxrkpc4w2l0=; b=UO6/O7dUgcomqAINfwlUczqNqBTtX4/0fB/3gxQ+/IP/VHlOvCktK/05l8Cn1COtVq 7CaaaAXcMTarml42yg62Ssd8HVqx3x9VOxpa9spoqQ/c3X1KQ6EXOQb27zYLhuLjXORi DRg7m+qiaLYzkNk4aJxMQe+58/dhMdeknGMqviIvjANu/gaqltrk2Azwdh3b7QJsJvHM VZpjbBoM7ZvGeDjWr0p2hTIDFxObLDbyz/S4xO4rO6X7IzuKZ8c/hiRJLptIOYgWr8Uv AXF7ZA0tyhTUDJPh54JDP9k8k88PTWZECutZTm6YPozGLOpo5/nUeL10EM/1+5CVyHx5 vyYQ== Received: by 10.152.145.162 with SMTP id sv2mr1043675lab.41.1355004284467; Sat, 08 Dec 2012 14:04:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.43.229 with HTTP; Sat, 8 Dec 2012 14:04:13 -0800 (PST) In-Reply-To: <50C3B788.6050809@FreeBSD.org> References: <50C3AEE6.3020101@FreeBSD.org> <50C3B788.6050809@FreeBSD.org> From: Eitan Adler Date: Sat, 8 Dec 2012 17:04:13 -0500 Message-ID: Subject: Re: Patch for porter's handbook To: Guido Falsi Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlYdqdPPthnPXXi2FLXu/QNu5oTSMh/aU0CJWPdurF2trjCiH9FSzmFTX/z/LN+XddANpE6 Cc: freebsd-doc@freebsd.org, bapt@freebsd.org X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Dec 2012 22:04:46 -0000 On 8 December 2012 16:56, Guido Falsi wrote: > On 12/08/12 22:22, Eitan Adler wrote: >> >> On 8 December 2012 16:19, Guido Falsi wrote: >>> >>> Hi! >>> Some time ago the maintainer of net-mgmt/mrtg noticed that the porter's >>> handbook still reference NOPORTDOCS in place of the new DOCS option in >>> optionsng. >>> >>> I have a patch(attached) which fixes this. bapt has already seen it and >>> approved it, as suggested by him I added a tag around "DOCS". >>> >>> I'd like this patch to be revised by someone of the documentation team >>> and >>> approved for committing it. I'm obviously accepting any comment or >>> correction. >> >> >> The content changes look good. However, please don't make whitespace / >> formatting changes in the same patch as this makes it harder to figure >> out what changed for both the reviewers and translators. >> >> > > Good point. Here is a revised patch with only the content changes included. Looks good to me. Not your text but: "and neither would be added to port packing list" doesn't sound quite right. Try replacing "and neither would be" with "or". -- Eitan Adler