Date: Fri, 05 Jan 2024 15:22:04 +0100 From: Olivier Certner <olce@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bd61c1e89dc4 - main - libthr: thr_attr.c: Clarity, whitespace and style Message-ID: <4872425.Cjmsv3J8Qz@ravel> In-Reply-To: <ZZeRdBkTSZGxXYz0@kib.kiev.ua> References: <202401041044.404AiIN0046997@gitrepo.freebsd.org> <2782916.iL6vRArjjl@ravel> <ZZeRdBkTSZGxXYz0@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1885913.vR5SVPPSqJ Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Olivier Certner <olce@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Date: Fri, 05 Jan 2024 15:22:04 +0100 Message-ID: <4872425.Cjmsv3J8Qz@ravel> In-Reply-To: <ZZeRdBkTSZGxXYz0@kib.kiev.ua> MIME-Version: 1.0 Hi, > Also we usually discourage plain style changes or tweaks unless they are > preparations for more substantial change. Yes, I'm aware of that. It's a fixture of most projects, and generally a good one IMHO. Besides D43006, there will be several other changes to 'thr_attr.c' (and to 'libthr' more generally). > Can you show the place where it happens? Because the canonical style is > reverse, non-bool values must be explicitly tested instead of relying on > the implicit conversion to bool. I was referring to D40626 and D40642, but it may be considered a different situation because, there, an integer, whatever its actual numerical value, is used as a boolean flag as a whole and there is no '&' to extract a particular bit. Please have a look at the small series starting at D43327 (up to D43330) for the modifications you suggested and a few additional ones of mine. Thanks and regards. -- Olivier Certner --nextPart1885913.vR5SVPPSqJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmWYEIwACgkQjKEwQJce JiezGRAAhegMijLauFoK/gPL9JV+/nesiusddm9J9Sk+Y7WdusscK5J7eUjwMsQX WpBJ3L3kUHiP7bGCKb1MLN14nSH/FKCxIFFCwq8/eYeM74fFZijp3HWDlNSKD+TZ q7DGSjrXbLR2UyzfspeYCG9J6qS6fYc3lKI6zRB6aI0uAKRNizdoL4e8bsb1YgcU lBPMyao/M9vUufPrOcFBApt8BKeAXiudOjs80MKno6UjfDuXQHx/LnKekHZfpPg6 WTTZJIoV+pDDG5r3fDAioz9P0cp5vaLrxcZU7qH/PSEZsgtlSl6725I9cmlF2/hw btZ4eajBeFUX3di+yfmOfp677VP+w9TJZMMkQOb1s8Jk0BexqUCerZPy9E3FKn6P H5E9TKlqEKoUlKAyM4hShBwfE92tuNp23D0e4EhBi01mz+caFIf5g98WQKdgnHhC mrM+7oUOLX3gVkoy3ddD2Jyr8SUlHTfQ7LhDGxU1pHWagzxMalH/RK/VzIoDbQjA qcLVM3Xg0RLseRD9wuzmvkBZMiWvSzaN+O4nPFyUB6KcppYr4XyvH001/UWtcnfL HOHKgQeTLa1bj1phzpznSKBt8fIxCjqhst8BFZKFnfwSpqFHIEhBDWd0J2Pqz8mb +3tjr4LRJBX48rhdzENLAlt/QN5UUEZSCVvApBsVPi0/pQuj35Y= =I0sI -----END PGP SIGNATURE----- --nextPart1885913.vR5SVPPSqJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4872425.Cjmsv3J8Qz>