From owner-dev-commits-src-main@freebsd.org Fri Jan 8 09:27:14 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5FEF14C2B73; Fri, 8 Jan 2021 09:27:14 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DByRk2FCPz3Lxc; Fri, 8 Jan 2021 09:27:14 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 268EB2EACE; Fri, 8 Jan 2021 09:27:14 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 0F4E5EC8CB; Fri, 8 Jan 2021 10:26:38 +0100 (CET) Date: Fri, 8 Jan 2021 10:26:38 +0100 From: Baptiste Daroussin To: Vladimir Kondratyev Cc: Ravi Pokala , Jessica Clarke , Vladimir Kondratyev , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. Message-ID: <20210108092638.x2kkvpeftey2wk62@ivaldir.net> References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pvwjn3u42ifxw2qb" Content-Disposition: inline In-Reply-To: X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 09:27:14 -0000 --pvwjn3u42ifxw2qb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 08, 2021 at 02:49:31AM +0300, Vladimir Kondratyev wrote: > On 08.01.2021 02:41, Ravi Pokala wrote: > > -----Original Message----- > > From: on behalf of Vladimir Kondraty= ev > > Date: 2021-01-07, Thursday at 15:33 > > To: Jessica Clarke , Vladimir Kondratyev > > Cc: "src-committers@freebsd.org" , "dev-com= mits-src-all@freebsd.org" , "dev-commits-s= rc-main@freebsd.org" > > Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to = libkern. > >=20 > > On 08.01.2021 02:27, Jessica Clarke wrote: > > > On 7 Jan 2021, at 23:20, Vladimir Kondratyev w= rote: > > >> +#include > > >> +#include > > >> +#include "xlocale_private.h" > > >> + > > >> +/* > > >> + * Find the first occurrence of find in s, ignore case. > > >> + */ > > >> +char * > > >> +strcasestr_l(const char *s, const char *find, locale_t locale) > > >=20 > > > Locales in the kernel? This feels wrong. > > >=20 > > > Jess > > >=20 > >=20 > > strcasestr.c was copied from userland unmodified just to allow > > "git log --follow" to work. Next commit removed locale support from= this > > file and connected it to build. > >=20 > > Unfortunately, about two-dozen commit messages from you arrived at the = same time, and some were out of order; without incrementing change numbers = in the subject line, figuring out the actual ordering is non-trivial. :-p > >=20 > > -Ravi (rpokala@) > >=20 >=20 > I hope, commit hook will be improved some day. Pushing of two-dozen > commits one by one is too boring. The history is in the right order and gitlog/cgit/anything that reads the l= og show everything in the right order. mails are asynchronuous, expecting the mail to always arrive in a given ord= er is wrong ;) pushing all those commits at once was imho the right thing to do. Best regards, Bapt --pvwjn3u42ifxw2qb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl/4JUsACgkQY4mL3PG3 PlrGlw/9H8MYzsk+I2mrmVaeoVZ5O1xUQ1yuQusSR6q+AApXcHOKbPuW1VTF+R+F sCIsbMQZJwCJDUkpwTfw7SXanz1WjhGPd2hstxDUlmgdQWPirHZjJCkSu9la0WDk SEq/FqH/tBIN8kJWeegMo8AobQWbpgt+tkW6U8eSygSKsEL2QpKzbxjAd4CQlwH1 rgv1eg19RLS6/B4AAty9GOOWtN5MQYrVRBmuNQQmmTKYfDRav4Zgb/hgt1MPdtU5 8Y++nYtSkk0AfIhHPX3dHPMZhxJUyqpyFKe3UjI3tPk8AJV68Xx8WN3gjb2+ObVH 9ecWzkl6aypbceBOhcrt5KBowa0r2x14fwEolgI8mmhPRGRp0oCtzi/PRhd39E+d jDYDO92qNJ/ie/fbXKAjXiDTM3zAU2w1ZsiixPW/s5huoSd+9N9Z0sP+vjqnqpc9 c3/UhHXY4OCndQgchcVlO1cYalLzaxif1GETunWyDI/oN8m+4hTGiTaUY/CxwIM8 wFCx8wcq+XQB+LS9w+zxuQQcuju9c6yvSsSbL5zoPyVHGTKVAUzh2K563KdzoKtg 2WF+h1XzLcGm5ONBhjwx+Ki9kRbv/Tr4TD7xESscf6PL5uL0MFC/JhByLX8jOOoQ 4dBAvIt2vYPtVEgp67HHMEpIa11kerFGuaPS9rMpyvu2yaPoqVE= =LQmH -----END PGP SIGNATURE----- --pvwjn3u42ifxw2qb--