From owner-freebsd-current@FreeBSD.ORG  Mon Nov 25 12:36:46 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0C1C415A;
 Mon, 25 Nov 2013 12:36:46 +0000 (UTC)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id BB5192638;
 Mon, 25 Nov 2013 12:36:45 +0000 (UTC)
Received: from [192.168.2.2] (unknown [77.243.161.229])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id B998B5C43;
 Mon, 25 Nov 2013 13:36:33 +0100 (CET)
Content-Type: multipart/signed;
 boundary="Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\))
Subject: Re: Buildworld broken with WITHOUT_DYNAMICROOT=yes in src.conf
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <20131125075110.GL59496@kib.kiev.ua>
Date: Mon, 25 Nov 2013 13:36:15 +0100
Message-Id: <063D36C2-E1D0-449E-A662-0CCA5A9B887E@FreeBSD.org>
References: <201311250111.rAP1BuI0009520@pozo.com>
 <20131125011949.GC1627@glenbarber.us> <20131125012302.GD1627@glenbarber.us>
 <201311250129.rAP1TJfQ033437@pozo.com> <20131125041724.GA2310@glenbarber.us>
 <201311250441.rAP4freb002330@pozo.com> <20131125044854.GC2310@glenbarber.us>
 <20131125075110.GL59496@kib.kiev.ua>
To: Konstantin Belousov <kostikbel@gmail.com>
X-Mailer: Apple Mail (2.1822)
Cc: Glen Barber <gjb@FreeBSD.org>,
 freebsd-current <freebsd-current@freebsd.org>, peter@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Nov 2013 12:36:46 -0000


--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 25 Nov 2013, at 08:51, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Sun, Nov 24, 2013 at 11:48:54PM -0500, Glen Barber wrote:
...
>> Index: Makefile
>> ===================================================================
>> --- Makefile      (revision 258538)
>> +++ Makefile      (working copy)
>> @@ -42,6 +42,9 @@
>> 
>> DPADD=	${LIBTERMCAP} ${LIBCRYPT}
>> LDADD=	-ltermcap -lcrypt
>> +.if ${MK_ICONV} != "no" && ${MK_DYNAMICROOT} != "yes"
>> +LDADD+=    -lc_nonshared
>> +.endif
>> 
>> LINKS=	${BINDIR}/csh ${BINDIR}/tcsh
>> 
> 
> No, this is wrong.  As is, static linking is broken and the hack above
> only fixes one case.
> 
> What is needed is inclusion of the lib/libc_nonshared object files into
> static libc.a.  I am not sure how to express this in our build system.

Hi Kostik,

You can add the additional object files to ${STATICOBJS}.  These will
only be built for the static and profiled libraries.  See for example
gnu/lib/libgcc/Makefile or lib/libc++/Makefile.

-Dimitry


--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iEYEARECAAYFAlKTREoACgkQsF6jCi4glqOEIgCfZ33y/qfivaOAlC3s3px0qJXx
MsoAnibbBjhrkxVRp/QGFZvI7OBp5+T4
=QfPp
-----END PGP SIGNATURE-----

--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE--