From owner-svn-src-all@FreeBSD.ORG Mon Nov 24 13:49:50 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C72C1065673; Mon, 24 Nov 2008 13:49:50 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 4E3D48FC1B; Mon, 24 Nov 2008 13:49:50 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 5CC6B6D449; Mon, 24 Nov 2008 13:49:49 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 4081A844AD; Mon, 24 Nov 2008 14:49:49 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Sean Farley References: <200811232326.mANNQCLp067323@svn.freebsd.org> Date: Mon, 24 Nov 2008 14:49:49 +0100 In-Reply-To: <200811232326.mANNQCLp067323@svn.freebsd.org> (Sean Farley's message of "Sun, 23 Nov 2008 23:26:12 +0000 (UTC)") Message-ID: <86wsetfd36.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185237 - head/lib/libutil X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2008 13:49:50 -0000 Sean Farley writes: > Log: > Fixed style issues with variable ordering and naming, spacing and > parentheses. >=20=20=20 > Fixed alignment issue in gr_dup() in its assignment of gr_mem using a > struct to force alignment without performing alignment mathematics. Th= is > was noticed recently with libutil was built with WARNS=3D6 on platform = such > as sparc64. >=20=20=20 > Added checks to gr_dup(), gr_equal() and gr_make() to prevent segfaults > when examining struct group's with the struct members pointing to NULL'= s. >=20=20=20 > With fix of alignment issue, restore WARNS?=3D6. Good work, thank you! DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no