From owner-freebsd-ports@FreeBSD.ORG Wed Jan 3 19:46:07 2007 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E55516A407 for ; Wed, 3 Jan 2007 19:46:07 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.freebsd.org (Postfix) with ESMTP id 7B39D13C428 for ; Wed, 3 Jan 2007 19:46:06 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id 6D0009C08F0; Wed, 3 Jan 2007 20:46:04 +0100 (CET) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ek+Wpn93ud2k; Wed, 3 Jan 2007 20:45:59 +0100 (CET) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.t-hosting.hu (Postfix) with ESMTP id AE9C19C08FA; Wed, 3 Jan 2007 20:45:59 +0100 (CET) Message-ID: <459C07F4.5050209@FreeBSD.org> Date: Wed, 03 Jan 2007 20:45:56 +0100 From: Gabor Kovesdan User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Andrew Pantyukhin References: <200701011956.14607.freebsd@alaskaparadise.com> <200701021418.18003.jonas@schiebtsich.net> <200701021327.42947.freebsd@alaskaparadise.com> <459ADFF6.9050105@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd@alaskaparadise.com, ports@freebsd.org, Wesley Shields Subject: Re: PLIST_FILES question X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2007 19:46:07 -0000 Andrew Pantyukhin schrieb: > On 1/3/07, Gabor Kovesdan wrote: >> Beech Rintoul schrieb: >> > Thanks to everyone who responded. I somehow missed that handbook >> section, but >> > I have it figured out now. What I needed to do is the following: >> > >> > .if defined(WITH_MYSQL) >> > USE_MYSQL= yes >> > MODULES:=${MODULES}:mod_sql:mod_sql_mysql >> > INCLUDEDIRS:=${INCLUDEDIRS}:${LOCALBASE}/include >> > LIBDIRS:=${LIBDIRS}:${LOCALBASE}/lib/mysql >> > PLIST_FILES= include/proftpd/mod_sql.h >> > .endif >> > >> > The extra header file is not copied to include unless that option >> is checked >> > and hard coding it in pkg-plist broke the pkg build. It didn't show >> up on >> > pointyhat because that option is off by default. >> > >> > >> >> Oh, do you want to mix PLIST_FILES and pkg-plist, did >> I catch it right? That should not be done. > > Why not? > >> You can list that file in pkg-plist as >> %%MYSQL%%include/proftpd/mod_sql.h and do the following in Makefile: >> >> if defined(WITH_MYSQL) >> PLIST_SUB+= MYSQL="" >> [...another things here...] >> .else >> >> PLIST_SUB+= MYSQL="@comment " >> .endif >> >> Look at e.g. security/amavisd-new, I do something similar there. > > PLIST_FILES is a bit simpler to use. Personal feelings > about the variable, or whether it smells well when mixed > with pkg-plist are interesting, but they are not quite > relevant if there's no technical problem. Well, I don't know why portlint warns you about it, but I also think it should be avoided. I think it's just misleading. When I look at a port I presuppose it uses either pkg-plist or PLIST_FILES, but not both, since it is the common practise, and probably other people think in this way, so one might overlook PLIST_FILES if one sees that pkg-plist exists. Gabor