Date: Wed, 14 Jun 2017 19:44:49 -0600 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: "Tobias C. Berner" <tcberner@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443599 - head/Mk Message-ID: <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org> In-Reply-To: <20170615005515.GA26393@FreeBSD.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> <20170615005515.GA26393@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 14 Jun, 2017, at 18:55, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >=20 > On Wed, Jun 14, 2017 at 08:18:38PM +0000, Tobias C. Berner wrote: >> New Revision: 443599 >> URL: https://svnweb.freebsd.org/changeset/ports/443599 >>=20 >> Log: >> Add note, that WRKDIRPREFIX must not end in '/'. >>=20 >> PR: 199297 >=20 > This is stupid, fragile, error-prone appoach that does not even cover = all > cases (like shown in the PR) when no paths end in slash but the = problem > still occurs. Did you read the analysis of my original problem = carefully > enough? It was not about slashes, it was symlinks and realpath. >=20 > You might not like proposed solution but then think of something = better; > computers are smart enough to handle slashes automagically rather than > depend on that unrealiable human beings will follow the rules and = notes. Okay, but WRKDIRPREFIX still shouldn't end in a slash though, and a = comment saying not to put a slash at the end is a pretty reasonable = move. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94>