From nobody Tue Feb 17 00:29:03 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFL9W6CpDz6SbRg for ; Tue, 17 Feb 2026 00:29:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFL9W4Bw4z3Td9 for ; Tue, 17 Feb 2026 00:29:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771288143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uX+8IpyOadKYZmRsijnAbxXerBLOFCSEzVqim+SknQk=; b=e8Bab1bMAuNEp12O+t6UPlcz5lXvwWvuOGy4deb+5gs2fW7EJkHseXmB0MGuFehZUCNe7/ QCcM4W3mjqFLhSJV1gDBD08//dWW0VjnfV8Wrfl2ArVHKqbjCex1cH0z6+r6B1lyKsReCJ h6T0sJQi2b1NULaE/JzDhSqXN0uiJkWD3Uh4io/1sjYtDuKJ2tYaQhA1DTS7c8mthOCFSA VZaj0Yd/uYkCYLOM8DJO+Vwat33hpykEqoOnEoC8qM0rOyfeyLT6V5qS3zXMF5Ffw9KV91 OpdvbJrkDkzn7buOJWGjB2sT9JWWu0jQ3n53KuwcTrZjeUoGinLH7n6ghT8wCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771288143; a=rsa-sha256; cv=none; b=x4LsIlcRSYTQxE2BrE9arSy84X3gAIvcydCF30Pj3g4unQw7ETz/wVV0ydgsU6ZjZxqTIr i3NDIWe2GsPkFhjPzgxsexPtBt7uhNQkrFXpmdbXTvVMlTqLTdWQiJ/vTv0l+bCmiECBR/ 0IKsYB5s80fKsLGI0AVH8D+yauM+SpkPsJ0iSUx6JofxYs7Xat+3XFFMch6thvzopw44RZ oGZToiS2y3KmzKq0A1H7YQk2RvuoR5wIO9koOXfwnPu02ZVKjzpR/DElasTVchihUCMSrL stAjejtuiPRKmc0YR4HxDgMDVzq4qq3oV/MdCq0ae5MvY/CwPxQMuRYBgz0t0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771288143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uX+8IpyOadKYZmRsijnAbxXerBLOFCSEzVqim+SknQk=; b=hBRSbRrv5/b0eSVX85zzcQWyrzwHNmvRwCpzIbb0hGINxMMKn3udPgrG68eTrBgYMcL2Js ukMXppjeqSeODTJ9atSxDmBAkmcG1qoe1Q6owWb2ZJ0NEjUwkh/nsMCT0UVyiEpAStK5Nv 6RivX1NK761s4K4VYd2BCvTUHYNs3qWzyuglfoD9wuLSvxqy6SRtjVVJLIRxs0JoSb2nos YPPUyYi/rJv9D8fJL9+xg/4lTBOzzk1+v78BlvAiB19yc1yZRkiOTO5ov3JpbNm50VS+U2 FaeowtNYnsXpB/VYmHG6lxXW4UFjfwMKbH6wLUiGF/FOe5Q9x08ybQF2dTfIXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fFL9W2jg1zmq1 for ; Tue, 17 Feb 2026 00:29:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36869 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Feb 2026 00:29:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: 05492ff6f636 - main - pdwait(2) tests: do not rely on (int *)-1 being invalid address List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05492ff6f636108c4fac40c259defe9b2eac7833 Auto-Submitted: auto-generated Date: Tue, 17 Feb 2026 00:29:03 +0000 Message-Id: <6993b64f.36869.6246406@gitrepo.freebsd.org> The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=05492ff6f636108c4fac40c259defe9b2eac7833 commit 05492ff6f636108c4fac40c259defe9b2eac7833 Author: Alan Somers AuthorDate: 2026-02-17 00:25:58 +0000 Commit: Alan Somers CommitDate: 2026-02-17 00:27:38 +0000 pdwait(2) tests: do not rely on (int *)-1 being invalid address Explicitly mmap guard and use it as the invalid address instead. MFC after: 1 week --- tests/sys/kern/pdwait.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/sys/kern/pdwait.c b/tests/sys/kern/pdwait.c index 513b07cae87e..c7b2c40a87ba 100644 --- a/tests/sys/kern/pdwait.c +++ b/tests/sys/kern/pdwait.c @@ -27,6 +27,7 @@ #include #include +#include #include #include #include @@ -37,6 +38,16 @@ #include #include +static void* +unmapped(void) { + void *unmapped; + + unmapped = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_GUARD, -1, 0); + ATF_REQUIRE(unmapped != MAP_FAILED); + + return(unmapped); +} + /* basic usage */ ATF_TC_WITHOUT_HEAD(basic); ATF_TC_BODY(basic, tc) @@ -108,7 +119,8 @@ ATF_TC_BODY(efault1, tc) ATF_REQUIRE_MSG(pid >= 0, "pdfork failed: %s", strerror(errno)); ATF_REQUIRE_MSG(fdp >= 0, "pdfork didn't return a process descriptor"); - ATF_CHECK_ERRNO(EFAULT, pdwait(fdp, (int*)-1, WEXITED, NULL, NULL) < 0); + ATF_CHECK_ERRNO(EFAULT, + pdwait(fdp, (int*)unmapped(), WEXITED, NULL, NULL) < 0); close(fdp); } @@ -127,7 +139,8 @@ ATF_TC_BODY(efault2, tc) ATF_REQUIRE_MSG(fdp >= 0, "pdfork didn't return a process descriptor"); ATF_CHECK_ERRNO(EFAULT, - pdwait(fdp, NULL, WEXITED, (struct __wrusage*)-1, NULL) < 0); + pdwait(fdp, NULL, WEXITED, (struct __wrusage*)unmapped(), NULL) < 0 + ); close(fdp); } @@ -146,7 +159,8 @@ ATF_TC_BODY(efault3, tc) ATF_REQUIRE_MSG(fdp >= 0, "pdfork didn't return a process descriptor"); ATF_CHECK_ERRNO(EFAULT, - pdwait(fdp, NULL, WEXITED, NULL, (struct __siginfo*)-1) < 0); + pdwait(fdp, NULL, WEXITED, NULL, (struct __siginfo*)unmapped()) < 0 + ); close(fdp); }