From owner-freebsd-ppc Thu May 24 17:53:47 2001 Delivered-To: freebsd-ppc@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id EAE3037B422; Thu, 24 May 2001 17:53:44 -0700 (PDT) (envelope-from obrien@nuxi.ucdavis.edu) Received: from dragon.nuxi.com (root@[206.40.252.115]) by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f4P0rhl24916; Thu, 24 May 2001 17:53:43 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f4P0rhW13957; Thu, 24 May 2001 17:53:43 -0700 (PDT) (envelope-from obrien) Date: Thu, 24 May 2001 17:53:39 -0700 From: "David O'Brien" To: Benno Rice Cc: Doug Rabson , freebsd-ppc@FreeBSD.org Subject: Re: FreeBSD/powerpc work to date Message-ID: <20010524175339.A13912@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20010521234812.B56326@rafe.jeamland.net> <20010523101643.A70899@rafe.jeamland.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010523101643.A70899@rafe.jeamland.net>; from benno@FreeBSD.org on Wed, May 23, 2001 at 10:16:43AM +1000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-ppc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, May 23, 2001 at 10:16:43AM +1000, Benno Rice wrote: > > Nice! Reading through the changes, I have a couple of comments. In > > mp_machdep.c, you should remove the 'include ' - that is > > only ever likely to exist on alpha. You can alsp delete ipl.h since that > > has been removed for the other arches. > > Ah. I started with the code from NetBSD and pulled bits from around the tree > to fill gaps, so there's some weirdness in there. =) I would rather not see things with NetBSD weirdness we do not understand committed. Otherwise these bits will last forever and we'll have a platform who's code smells different from the other smelling two we already have. I cannot tell from your reply if you are going to act on DFR's issue. You only explained the why, not what you plan to do about it. > > In swtch.s, you are correct in thinking that Idle is unneeded. A generic > > assembler question - why the use of _C_LABEL(xx)? Surely since we are only > > ever going to be using ELF here, we can assume the format of C names? Its > > difficult to see what is happening since I'm not familiar with powerpc > > assembler but it appears that you are saving the process state on the > > stack (using a 'struct switchframe'). The other architectures save this > > information in the PCB - I'm not sure which is the best place. > > This is probably NetBSD code. Since I haven't got that far yet, it's pretty > much unchanged except that I separated their locore.s into smaller files as > per the other FreeBSD ports. See my concerns above. I especially feel this way about strange macros. Those of us reading both Alpha and x86 headers often have to scratch our heads what these NetBSD macros do, etc.. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ppc" in the body of the message