From owner-freebsd-net@FreeBSD.ORG Thu Nov 8 21:48:22 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D476126F; Thu, 8 Nov 2012 21:48:22 +0000 (UTC) (envelope-from melifaro@FreeBSD.org) Received: from mail.ipfw.ru (unknown [IPv6:2a01:4f8:120:6141::2]) by mx1.freebsd.org (Postfix) with ESMTP id 8D7458FC08; Thu, 8 Nov 2012 21:48:22 +0000 (UTC) Received: from v6.mpls.in ([2a02:978:2::5] helo=ws.su29.net) by mail.ipfw.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76 (FreeBSD)) (envelope-from ) id 1TWa0r-0003QI-UJ; Fri, 09 Nov 2012 01:51:50 +0400 Message-ID: <509C2899.8010701@FreeBSD.org> Date: Fri, 09 Nov 2012 01:48:09 +0400 From: "Alexander V. Chernikov" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120121 Thunderbird/9.0 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: [patch] reducing arp locking References: <509AEDAC.10002@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, freebsd-hackers@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2012 21:48:23 -0000 On 08.11.2012 03:46, Adrian Chadd wrote: > On 7 November 2012 15:24, Alexander V. Chernikov wrote: >> Hello list! >> >> Currently we need to acquire 2 read locks to perform simple 6-byte copying >> from arp record to packet ethernet header. >> >> It seems that acquiring lle lock for fast path (main traffic flow) is not >> necessary even with current code. >> >> My tests shows ~10% improvement with this patch applied. >> >> If nobody objects I plan to commit this change at the end of next week. > > That's a great catch! How'd you discover it? We have lots of FreeBSD routers doing 10G firewalling, so we're very much concerned with forwarding/firewalling performance, constantly looking for something to optimize :) > > > > Adrian >