From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Sep 12 03:10:39 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1352894E for ; Fri, 12 Sep 2014 03:10:39 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE0B6C8D for ; Fri, 12 Sep 2014 03:10:38 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8C3AcVu016266 for ; Fri, 12 Sep 2014 03:10:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193542] [MAINTAINER] x11-fonts/alef: Bump PORTREVISION Date: Fri, 12 Sep 2014 03:10:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jhale@FreeBSD.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2014 03:10:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193542 Jason E. Hale changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Triage |In Discussion CC| |jhale@FreeBSD.org --- Comment #2 from Jason E. Hale --- - Comment should not start with indefinite article "A" - Installation commands should not be muted (mkdirs OK) - Installation of DOCS should not be conditional. Staging will take care of it automatically - To install the DOCS without the for loop, the easiest way is: ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR} - This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use - It should be running mkfontdir(1) and mkfontscale(1) in the directory where the fonts are. Of course, the generated files need added to pkg-plist. - It would be better if NO_WRKSUBDIR were set, then you wouldn't have to redefine WRKSRC and it would eliminate the first two lines of the post-extract target. - Since LICENSE_FILE is being added, it should be removed from PORTDOCS so that it isn't installed twice -- You are receiving this mail because: You are the assignee for the bug.