From owner-freebsd-net@FreeBSD.ORG Fri Apr 3 17:02:40 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9543CD; Fri, 3 Apr 2015 17:02:40 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 94F935E9; Fri, 3 Apr 2015 17:02:40 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id E84F310B154; Fri, 3 Apr 2015 10:02:39 -0700 (PDT) Date: Fri, 3 Apr 2015 10:02:39 -0700 From: hiren panchasara To: Adrian Chadd Subject: Re: Full 32bit flowid from igb(4) Message-ID: <20150403170239.GD72165@strugglingcoder.info> References: <20150324154931.GC53237@strugglingcoder.info> <20150330225945.GI10892@strugglingcoder.info> <20150331050628.GJ10892@strugglingcoder.info> <20150331170933.GK10892@strugglingcoder.info> <20150403165411.GC72165@strugglingcoder.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="llIrKcgUOe3dCx0c" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Jack F Vogel , FreeBSD Net , erj@freebsd.org, Jack Vogel , Jason Wolfe X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2015 17:02:40 -0000 --llIrKcgUOe3dCx0c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/03/15 at 10:00P, Adrian Chadd wrote: > On 3 April 2015 at 09:54, hiren panchasara w= rote: > > On 03/31/15 at 11:15P, Adrian Chadd wrote: > >> Yeah, I think the right thing to do is: > >> > >> * If the descriptor says it's RSS, then use the flowid + rss type > > So, if we have multiqueue, we do everything needed to get RSS > > flowid/type. That means, with num_queues > 1 we can just expose those. > > > >> * else, set it to queue id and set the type to opaque. > > > > This part becomes irrelevant as it's a single queue case. Do we care > > about setting flowid value/type in case of single queue? >=20 > My whole point with not always setting it is that people may do things > to /other/ parts of the driver and suddenly the RSS field isn't the > RSS field anymore. >=20 > Doubly so if you start playing with multiqueue + flowdirector on ixgbe. :) >=20 > So I'd rather the driver be right and correct - checking if the field > /is/ RSS and only setting the flowid+flowtype /if/ the value in that > register is an RSS flowid, rather than setting it to whatever's there > and hoping it's an RSS value. :) Okay, I guess it doesn't hurt to read those registers again at the time of actually assigning flowid/type. I'll do that and post a review on phabricator. Cheers, Hiren --llIrKcgUOe3dCx0c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVHsevXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/la70H/jTWqxtkQxzF6HaOfkO4jXKb AIYB3fgM2o5UjcvQ18F7MT5u2oRMk17jJhEb0BwUs0BJwljFprd3Q72pM41xr894 qGn1Px0fLs+RbtCyaDgLJKnx1lIzxpCbsq8f0cV4hjBQ+oM4aiLC4yk0S0MkLR8T UlgaeVzP9+zQ5OgfIZ23fS0Y4ZPMZQBWAfw8d5JeRxS+EP+oWoLqpsPfVXbqVrPs nLKp7QGx5PMfK5YfBcCdbvTqoF0Deto2I/TdIMTfMbfjj7yW5tquzagPHKsz3FMX ATWF7Ew2XnVPicMEAH1BmUUBogKx5yfWF9FrPM5oPnReBISp+u2Xt0feea26U0g= =xmQ9 -----END PGP SIGNATURE----- --llIrKcgUOe3dCx0c--