Date: Fri, 3 Apr 2015 10:02:39 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: Adrian Chadd <adrian@freebsd.org> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, erj@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jason Wolfe <nitroboost@gmail.com> Subject: Re: Full 32bit flowid from igb(4) Message-ID: <20150403170239.GD72165@strugglingcoder.info> In-Reply-To: <CAJ-VmokzcHKHYanmwFgB_4d8CJKajs6G7gY11_J4nWGf3JAUkQ@mail.gmail.com> References: <20150324154931.GC53237@strugglingcoder.info> <CAJ-Vmo=ajfWokQ3bdu1Ww8kV3AdVwwsDpoS9y_%2Bywk%2BgcrbBvQ@mail.gmail.com> <20150330225945.GI10892@strugglingcoder.info> <CAJ-Vmom1tE6g=ta-DPLDF%2Bnp0GOpFYOXn=PkspaALfazz-n4Gg@mail.gmail.com> <20150331050628.GJ10892@strugglingcoder.info> <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com> <20150331170933.GK10892@strugglingcoder.info> <CAJ-Vmok19d4K0ucvsxc8kUmpv0e2L7CHkYjgNC56sg_wigC1cQ@mail.gmail.com> <20150403165411.GC72165@strugglingcoder.info> <CAJ-VmokzcHKHYanmwFgB_4d8CJKajs6G7gY11_J4nWGf3JAUkQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--llIrKcgUOe3dCx0c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/03/15 at 10:00P, Adrian Chadd wrote: > On 3 April 2015 at 09:54, hiren panchasara <hiren@strugglingcoder.info> w= rote: > > On 03/31/15 at 11:15P, Adrian Chadd wrote: > >> Yeah, I think the right thing to do is: > >> > >> * If the descriptor says it's RSS, then use the flowid + rss type > > So, if we have multiqueue, we do everything needed to get RSS > > flowid/type. That means, with num_queues > 1 we can just expose those. > > > >> * else, set it to queue id and set the type to opaque. > > > > This part becomes irrelevant as it's a single queue case. Do we care > > about setting flowid value/type in case of single queue? >=20 > My whole point with not always setting it is that people may do things > to /other/ parts of the driver and suddenly the RSS field isn't the > RSS field anymore. >=20 > Doubly so if you start playing with multiqueue + flowdirector on ixgbe. :) >=20 > So I'd rather the driver be right and correct - checking if the field > /is/ RSS and only setting the flowid+flowtype /if/ the value in that > register is an RSS flowid, rather than setting it to whatever's there > and hoping it's an RSS value. :) Okay, I guess it doesn't hurt to read those registers again at the time of actually assigning flowid/type. I'll do that and post a review on phabricator. Cheers, Hiren --llIrKcgUOe3dCx0c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVHsevXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/la70H/jTWqxtkQxzF6HaOfkO4jXKb AIYB3fgM2o5UjcvQ18F7MT5u2oRMk17jJhEb0BwUs0BJwljFprd3Q72pM41xr894 qGn1Px0fLs+RbtCyaDgLJKnx1lIzxpCbsq8f0cV4hjBQ+oM4aiLC4yk0S0MkLR8T UlgaeVzP9+zQ5OgfIZ23fS0Y4ZPMZQBWAfw8d5JeRxS+EP+oWoLqpsPfVXbqVrPs nLKp7QGx5PMfK5YfBcCdbvTqoF0Deto2I/TdIMTfMbfjj7yW5tquzagPHKsz3FMX ATWF7Ew2XnVPicMEAH1BmUUBogKx5yfWF9FrPM5oPnReBISp+u2Xt0feea26U0g= =xmQ9 -----END PGP SIGNATURE----- --llIrKcgUOe3dCx0c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150403170239.GD72165>