From owner-freebsd-apache@FreeBSD.ORG Sat May 8 12:44:17 2010 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D49C1065672 for ; Sat, 8 May 2010 12:44:17 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id 6A9478FC1C for ; Sat, 8 May 2010 12:44:16 +0000 (UTC) Received: (qmail invoked by alias); 08 May 2010 12:17:34 -0000 Received: from u18-124.dsl.vianetworks.de (EHLO [172.20.1.100]) [194.231.39.124] by mail.gmx.net (mp060) with SMTP; 08 May 2010 14:17:34 +0200 X-Authenticated: #1956535 X-Provags-ID: V01U2FsdGVkX199d6k6VUB9563X3KACTCqV7LRF1iwwG0fUWEA4e2 jnFNcRmX/TQwuc Message-ID: <4BE5565D.9020109@gmx.de> Date: Sat, 08 May 2010 14:17:33 +0200 From: olli hauer User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: pgollucci@FreeBSD.org, bug-followup@FreeBSD.org References: <201005072149.o47Ln5qM019000@freefall.freebsd.org> In-Reply-To: <201005072149.o47Ln5qM019000@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: Olli Hauer , apache@FreeBSD.org Subject: Re: ports/133704: www/apache22 apxs does not work as expected X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2010 12:44:17 -0000 pgollucci@FreeBSD.org wrote: > Synopsis: www/apache22 apxs does not work as expected > > State-Changed-From-To: analyzed->closed > State-Changed-By: pgollucci > State-Changed-When: Fri May 7 21:49:05 UTC 2010 > State-Changed-Why: > done and done! > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133704 > Hi, thanks for fixing this bug;) Btw. since you are a member off apache.org, maybe you want to close the following bugzilla issue. https://issues.apache.org/bugzilla/show_bug.cgi?id=47397 One note: The FreeBSD hack removes the line complete so it is possible to breaks apache if someone use apxs to control modules not installed by a port since it removes the line completely. What do you think about this hack (add an addition parameter [-r] to remove the line) --- patch_apxs.txt begins here --- --- /usr/local/sbin/apxs 2010-05-08 11:38:09.000000000 +0200 +++ apxs 2010-05-08 13:55:32.000000000 +0200 @@ -72,6 +72,7 @@ my $opt_i = 0; my $opt_a = 0; my $opt_A = 0; +my $opt_r = 0; my $opt_q = 0; my $opt_h = 0; my $opt_p = 0; @@ -148,12 +149,14 @@ print STDERR " [-Wl,] [-p] ...\n"; print STDERR " apxs -i [-S =] [-a] [-A] [-n ] ...\n"; print STDERR " apxs -e [-S =] [-a] [-A] [-n ] ...\n"; + # FreeBSD hack, remove the line instead commenting out + print STDERR " apxs -e [-r] [-A] [-n ] ...\n"; exit(1); } # option handling my $rc; -($rc, @ARGV) = &Getopts("qn:gco:I+D+L+l+W+S+eiaAp", @ARGV); +($rc, @ARGV) = &Getopts("qn:gco:I+D+L+l+W+S+eiaApr", @ARGV); &usage if ($rc == 0); &usage if ($#ARGV == -1 and not $opt_g); &usage if (not $opt_q and not ($opt_g and $opt_n) and not $opt_i and not $opt_c and not $opt_e); @@ -614,7 +617,7 @@ } else { # replace already existing LoadModule line # Custom FreeBSD mod - if ($opt_A) { + if ($opt_A and $opt_r) { $content =~ s|^(.*\n)#?\s*$lmd_re[^\n]*\n|$1|s; } else { --- patch_apxs.txt ends here ---