From owner-svn-src-all@FreeBSD.ORG Thu Jul 11 20:05:07 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 96D94328; Thu, 11 Jul 2013 20:05:07 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id AF29A11DA; Thu, 11 Jul 2013 20:05:06 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuwGAEAP31FR8aPm/2dsb2JhbABagwmDPr8VgQYXdIIjAQEFViIBEAsOCgkWDwkDAgECASceBgEMAQUCAQGID7dbj2EHg3UDkA6BLZdpgxM6 Received: from 230.163-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.163.230]) by relay.skynet.be with ESMTP; 11 Jul 2013 22:03:56 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r6BK3sr0029504; Thu, 11 Jul 2013 22:03:54 +0200 (CEST) (envelope-from tijl@coosemans.org) Message-ID: <51DF0FA5.4050106@coosemans.org> Date: Thu, 11 Jul 2013 22:03:49 +0200 From: Tijl Coosemans User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:17.0) Gecko/20130701 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Chisnall , Bruce Evans Subject: Re: svn commit: r253215 - head/lib/msun/src References: <201307111741.r6BHf5gQ060844@svn.freebsd.org> <51DEFEF7.4080709@coosemans.org> <7D521907-4802-4141-9A5E-40EB157A5AEF@FreeBSD.org> In-Reply-To: <7D521907-4802-4141-9A5E-40EB157A5AEF@FreeBSD.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JFRNAHPSRCEWMEIXBBSG" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 20:05:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JFRNAHPSRCEWMEIXBBSG Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-07-11 21:36, David Chisnall wrote: > On 11 Jul 2013, at 19:52, Tijl Coosemans wrote: >>> @@ -227,8 +250,6 @@ double expm1(double); >>> double fma(double, double, double); >>> double hypot(double, double); >>> int ilogb(double) __pure2; >>> -int (isinf)(double) __pure2; >>> -int (isnan)(double) __pure2; >> >> I think they should stay for the C90 case. >=20 > That would completely defeat the point of this entire exercise and be > redundant unless we aim to support a compiler that only supports C90 > and no GNU extensions, in which case you'll hit errors in cdefs.h, > long before you get to this point in an include. isnan(double) is part of SUSv2. It should be visible when compiling with -D_XOPEN_SOURCE=3D500. I think you need something like this: #if (__BSD_VISIBLE || __XSI_VISIBLE <=3D 500) && __ISO_C_VISIBLE < 1999 int isinf(double) __pure2; int isnan(double) __pure2; #endif ------enig2JFRNAHPSRCEWMEIXBBSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iF4EAREIAAYFAlHfD6oACgkQfoCS2CCgtitHbAD9FmMy9FG+6k9abgI2j5xP9LOD wYatLfRjnD/UGDjnPT0A/ihVf5GqJXKFCHvH2R163dYmnny3q0qlzQfk/B3wJKU/ =N4xj -----END PGP SIGNATURE----- ------enig2JFRNAHPSRCEWMEIXBBSG--