Date: Mon, 23 May 2011 21:20:47 +0100 From: Chris Rees <utisoft@gmail.com> To: Ed Schouten <ed@80386.nl> Cc: freebsd-ports@freebsd.org Subject: Re: Utmpx usage Message-ID: <BANLkTikU4jRXaQckZ-0=-MhDczrpo0No6Q@mail.gmail.com> In-Reply-To: <20110523085030.GJ59496@hoeg.nl> References: <BANLkTimVF_YgdJ_d6=-L5jmx_zVrbp0wBQ@mail.gmail.com> <20110522205003.GH59496@hoeg.nl> <BANLkTikpxDeE0CnALF22eiYXvuuOLkjsQw@mail.gmail.com> <BANLkTi=XCcOCs4zrVPYHzimzzpPJ34jXNg@mail.gmail.com> <20110523085030.GJ59496@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23 May 2011 09:50, Ed Schouten <ed@80386.nl> wrote:
> * Chris Rees <utisoft@gmail.com>, 20110523 10:40:
>> I've been perusing the linux manpage for utmp, and noticed that login and
>> getty deal with utmp for logins, and It's only init's job to deal with
>> logouts. Since runit is an init replacement, this makes perfect sense.
>
> Yeah; it probably acts as a safety belt for misbehaving tools that
> forget to write logout records. On FreeBSD logout records are written by
> pam_lastlog(8), making that logic in init(8) superfluous.
>
> You could consider calling getutxline() in a loop to obtain the ut_ids
> for a specific TTY.
>
Well, since I'm not going to maintain a fork of this, I'm going to
remove the code.
The code in our init for the same function:
static void
clear_session_logs(session_t *sp __unused)
{
/*
* XXX: Use getutxline() and call pututxline() for each entry.
* Is this safe to do this here? Is it really required anyway?
*/
}
so I think I'll blank it!
Thanks, and sorry for taking us down a long and pointless avenue.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTikU4jRXaQckZ-0=-MhDczrpo0No6Q>