From owner-svn-src-all@freebsd.org Thu May 5 17:53:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78D63B2ED5B for ; Thu, 5 May 2016 17:53:22 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 031CF17F7 for ; Thu, 5 May 2016 17:53:21 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lf0-x22a.google.com with SMTP id u64so105086875lff.3 for ; Thu, 05 May 2016 10:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GR4nUaN/1Gwa0HYmXsza1SBfij2qbK+l6w05o+9Mru8=; b=C86c6I32HIajshLeHBXw2iV9msV2RqLPk2gVdyfIJ4RO9O0F6YqbIMT+X3vHV2tKiU 95s2yEc2bXAlaq/78375RcLca7wBEjZRLAXUByfdqCI71s+8InWixRxQMb5pVkbQjAf4 5N+DX5Xz2m26IdJPc+is8Y6QpZnCvHvQUaCXX2vraTCv5gpYi7m1iIcBo/qKIFcEFGlh w4CzFB1Sg8QutynXwwkCqaBkKxdm/tb3iOoDLJw4ywlUmT8zhpjmqd0jRQiWSgmRn05R ADaJBtCXOpURz4jyhVS/hMJalbh8bHosz8QRX+Au3OVdvo5L4mOMh5aar3FhmL2s5u3I bghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GR4nUaN/1Gwa0HYmXsza1SBfij2qbK+l6w05o+9Mru8=; b=UG+zU4SK6QPHSG7ldOdIqdP79T35G8y+3yw9hyu6XhOuXokf932xjYGgV3qxRRcuvq Nz2zbuaixrhXCOcNAmYzi/qNjjfDpKdvlN3GzaEg60R8sC/FNIVvEp66AQLFExQ49VCb gGbWpnIvuvZ7wuXhEE48qTqNU+KXllLGK25N86gRkuuT9wOhmE3Uo3rJQ+8UBE4OhqoA YfDkSvK1PzeeiQsqMVCm6iMtwjNybSUv3Uz31CHnlHwUdLe7/zzRoriuWLSQY/Y+pp0z 03YLVee4QXA7pGLmw553u8lfKUycpxPl7iYMoJc2FHDHJ1Wt2kgu1qB5k+q9ZsIyMyrP zjkw== X-Gm-Message-State: AOPr4FWgU5SC3NIkJhc/xlQPBdF17ysW+pkm0j8EsrDfY7ESVbnIrGu3WfIIEvnvqnKlifB19gRyzMS/ueBj/g== X-Received: by 10.112.62.193 with SMTP id a1mr6616574lbs.22.1462470800093; Thu, 05 May 2016 10:53:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.205.1 with HTTP; Thu, 5 May 2016 10:53:00 -0700 (PDT) In-Reply-To: References: <201605042234.u44MYBMX054443@repo.freebsd.org> <2368543.Vvp613SNcD@ralph.baldwin.cx> From: Zbigniew Bodek Date: Thu, 5 May 2016 19:53:00 +0200 Message-ID: Subject: Re: svn commit: r299090 - in head: etc/mtree include lib/libbluetooth sbin/hastd share/man/man3 sys/dev/xen/blkback sys/kern sys/net sys/sys tests/sys tests/sys/sys usr.sbin/bluetooth/hccontrol To: Alan Somers Cc: John Baldwin , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Justin Gibbs Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 17:53:22 -0000 Hi, It broke build for ARM64 but fixed here: https://svnweb.freebsd.org/changeset/base/299124 Best regards zbb 2016-05-05 18:45 GMT+02:00 Alan Somers : > On Thu, May 5, 2016 at 10:31 AM, John Baldwin wrote: > > > On Wednesday, May 04, 2016 10:34:11 PM Alan Somers wrote: > > > Author: asomers > > > Date: Wed May 4 22:34:11 2016 > > > New Revision: 299090 > > > URL: https://svnweb.freebsd.org/changeset/base/299090 > > > > > > Log: > > > Improve performance and functionality of the bitstring(3) api > > > > > > Two new functions are provided, bit_ffs_at() and bit_ffc_at(), which > > allow > > > for efficient searching of set or cleared bits starting from any bit > > offset > > > within the bit string. > > > > > > Performance is improved by operating on longs instead of bytes and > > using > > > ffsl() for searches within a long. ffsl() is a compiler builtin in > both > > > clang and gcc for most architectures, converting what was a brute > force > > > while loop search into a couple of instructions. > > > > > > All of the bitstring(3) API continues to be contained in the header > > file. > > > Some of the functions are large enough that perhaps they should be > > uninlined > > > and moved to a library, but that is beyond the scope of this commit. > > > > Doesn't switching from bytes to longs break the ABI? That is, setting > bit > > 9 > > now has a different representation on big-endian systems (0x00 0x01 > before, > > now 0x00 0x00 0x01 0x00 on 32-bit BE, and 4 more leading 0 bytes on > > 64-bit). > > This means you can't have an object file compiled against the old header > > pass a bitstring to an object file compiled against the new header on > > big-endian > > systems. > > > > Even on little-endian systems if an old object file allocates storage > for a > > bitstring the new code might read off the end of it and fault (or return > > garbage if bits are set in the extra bytes it reads off the end)? > > > > Is the API is so little used we don't care? > > > > -- > > John Baldwin > > > > The API isn't used in any shared libraries, so the only risk would be if > it's used in a user application where the user's build system doesn't check > for changes in system libraries, and the user upgrades FreeBSD without > doing a clean build of his application, right? Am I missing any other > scenarios? Do we need to warn users with a line in UPDATING or something? > > This is similar to an upgrade of the C++ compiler. C++ objects built by > different minor versions of the compiler aren't guaranteed to be > compatible. > > -Alan > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >