From owner-svn-src-all@freebsd.org  Sat Nov  5 09:07:39 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB293C2D3FC;
 Sat,  5 Nov 2016 09:07:39 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2555083;
 Sat,  5 Nov 2016 09:07:38 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uA597Xl8034258
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sat, 5 Nov 2016 11:07:34 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uA597Xl8034258
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id uA597XJd034257;
 Sat, 5 Nov 2016 11:07:33 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sat, 5 Nov 2016 11:07:33 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r308314 - head/usr.bin/sed
Message-ID: <20161105090733.GT54029@kib.kiev.ua>
References: <201611042049.uA4Knxcx019490@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201611042049.uA4Knxcx019490@repo.freebsd.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Nov 2016 09:07:39 -0000

On Fri, Nov 04, 2016 at 08:49:59PM +0000, Pedro F. Giffuni wrote:
> Author: pfg
> Date: Fri Nov  4 20:49:59 2016
> New Revision: 308314
> URL: https://svnweb.freebsd.org/changeset/base/308314
> 
> Log:
>   sed(1): add LEGACY_BSDSED_COMPAT compile-time flag.
>   
>   In r297602, which included a __FreeBSD_version bump to 1100105, we changed
>   sed 'i' and 'a' from discarding whitespaces to conform with what GNU and
>   sysvish sed do.
>   
>   There are arguments in favor of keeping the old behavior but the new
>   behavior is also useful for migration purposes. It seems important to at
>   least consider the case of developers depending on the previous behavior,
>   so add a CFLAG to enable the old behaviour.
If such legacy behavior appears to be useful or even important for
real-world scenarios, I think that an environment variable controlling
it is more practical and traditional than the recompilation.